Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 10886059: Clear the favicon of a tab when navigating to a url on a different host. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.cc
===================================================================
--- chrome/browser/favicon/favicon_tab_helper.cc (revision 153636)
+++ chrome/browser/favicon/favicon_tab_helper.cc (working copy)
@@ -176,6 +176,10 @@
void FaviconTabHelper::DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {
+
+ // Reset the favicon
sky 2012/10/01 14:33:53 remove newline on 179. This comment echos what the
+ details.entry->GetFavicon() = FaviconStatus();
+
// Get the favicon, either from history or request it from the net.
FetchFavicon(details.entry->GetURL());
}
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698