Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2012)

Unified Diff: content/browser/worker_host/worker_process_host.cc

Issue 10885044: Remove storage context accessors from ResourceContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: teh Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/worker_host/worker_process_host.cc
diff --git a/content/browser/worker_host/worker_process_host.cc b/content/browser/worker_host/worker_process_host.cc
index e665f11b77c75730e0b7d84ea31f9562bd2449a5..0a964eb4ea8fa6c744a6416396257c625c31797c 100644
--- a/content/browser/worker_host/worker_process_host.cc
+++ b/content/browser/worker_host/worker_process_host.cc
@@ -94,10 +94,13 @@ void WorkerCrashCallback(int render_process_unique_id, int render_view_id) {
host->GetDelegate()->WorkerCrashed();
}
-WorkerProcessHost::WorkerProcessHost(ResourceContext* resource_context)
- : resource_context_(resource_context) {
+WorkerProcessHost::WorkerProcessHost(
+ ResourceContext* resource_context,
+ const WorkerStoragePartition& partition)
+ : resource_context_(resource_context),
+ partition_(partition) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- DCHECK(resource_context);
+ DCHECK(resource_context_);
process_.reset(
new BrowserChildProcessHostImpl(content::PROCESS_TYPE_WORKER, this));
}
@@ -200,8 +203,6 @@ bool WorkerProcessHost::Init(int render_process_id) {
#endif
cmd_line);
- fileapi::FileSystemContext* file_system_context =
- GetFileSystemContextForResourceContext(resource_context_);
ChildProcessSecurityPolicyImpl::GetInstance()->AddWorker(
process_->GetData().id, render_process_id);
if (!CommandLine::ForCurrentProcess()->HasSwitch(
@@ -213,7 +214,7 @@ bool WorkerProcessHost::Init(int render_process_id) {
// This is for the filesystem sandbox.
ChildProcessSecurityPolicyImpl::GetInstance()->GrantPermissionsForFile(
process_->GetData().id,
- file_system_context->sandbox_provider()->new_base_path(),
+ partition_.filesystem_context()->sandbox_provider()->new_base_path(),
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_CREATE |
base::PLATFORM_FILE_OPEN_ALWAYS |
@@ -230,7 +231,7 @@ bool WorkerProcessHost::Init(int render_process_id) {
// sandbox.
ChildProcessSecurityPolicyImpl::GetInstance()->GrantPermissionsForFile(
process_->GetData().id,
- file_system_context->sandbox_provider()->old_base_path(),
+ partition_.filesystem_context()->sandbox_provider()->old_base_path(),
base::PLATFORM_FILE_READ | base::PLATFORM_FILE_WRITE |
base::PLATFORM_FILE_WRITE_ATTRIBUTES |
base::PLATFORM_FILE_ENUMERATE);
@@ -238,7 +239,8 @@ bool WorkerProcessHost::Init(int render_process_id) {
// we know we've taken care of it.
ChildProcessSecurityPolicyImpl::GetInstance()->GrantPermissionsForFile(
process_->GetData().id,
- file_system_context->sandbox_provider()->renamed_old_base_path(),
+ partition_.filesystem_context()->sandbox_provider()->
+ renamed_old_base_path(),
base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_CREATE_ALWAYS |
base::PLATFORM_FILE_WRITE);
}
@@ -258,7 +260,7 @@ void WorkerProcessHost::CreateMessageFilters(int render_process_id) {
process_->GetHost()->AddFilter(resource_message_filter);
worker_message_filter_ = new WorkerMessageFilter(
- render_process_id, resource_context_,
+ render_process_id, resource_context_, partition_,
base::Bind(&WorkerServiceImpl::next_worker_route_id,
base::Unretained(WorkerServiceImpl::GetInstance())));
process_->GetHost()->AddFilter(worker_message_filter_);
@@ -269,14 +271,14 @@ void WorkerProcessHost::CreateMessageFilters(int render_process_id) {
process_->GetHost()->AddFilter(new FileAPIMessageFilter(
process_->GetData().id,
request_context,
- GetFileSystemContextForResourceContext(resource_context_),
+ partition_.filesystem_context(),
content::GetChromeBlobStorageContextForResourceContext(
resource_context_)));
process_->GetHost()->AddFilter(new FileUtilitiesMessageFilter(
process_->GetData().id));
process_->GetHost()->AddFilter(new MimeRegistryMessageFilter());
- process_->GetHost()->AddFilter(new DatabaseMessageFilter(
- content::GetDatabaseTrackerForResourceContext(resource_context_)));
+ process_->GetHost()->AddFilter(
+ new DatabaseMessageFilter(partition_.database_tracker()));
SocketStreamDispatcherHost* socket_stream_dispatcher_host =
new SocketStreamDispatcherHost(render_process_id,
@@ -285,8 +287,7 @@ void WorkerProcessHost::CreateMessageFilters(int render_process_id) {
process_->GetHost()->AddFilter(
new content::WorkerDevToolsMessageFilter(process_->GetData().id));
process_->GetHost()->AddFilter(new IndexedDBDispatcherHost(
- process_->GetData().id,
- content::GetIndexedDBContextForResourceContext(resource_context_)));
+ process_->GetData().id, partition_.indexed_db_context()));
}
void WorkerProcessHost::CreateWorker(const WorkerInstance& instance) {
@@ -578,7 +579,8 @@ WorkerProcessHost::WorkerInstance::WorkerInstance(
int worker_route_id,
int parent_process_id,
int64 main_resource_appcache_id,
- content::ResourceContext* resource_context)
+ content::ResourceContext* resource_context,
+ const WorkerStoragePartition& partition)
: url_(url),
closed_(false),
name_(name),
@@ -586,7 +588,8 @@ WorkerProcessHost::WorkerInstance::WorkerInstance(
parent_process_id_(parent_process_id),
main_resource_appcache_id_(main_resource_appcache_id),
worker_document_set_(new WorkerDocumentSet()),
- resource_context_(resource_context) {
+ resource_context_(resource_context),
+ partition_(partition) {
DCHECK(resource_context_);
}
@@ -594,7 +597,8 @@ WorkerProcessHost::WorkerInstance::WorkerInstance(
const GURL& url,
bool shared,
const string16& name,
- content::ResourceContext* resource_context)
+ content::ResourceContext* resource_context,
+ const WorkerStoragePartition& partition)
: url_(url),
closed_(false),
name_(name),
@@ -602,7 +606,8 @@ WorkerProcessHost::WorkerInstance::WorkerInstance(
parent_process_id_(0),
main_resource_appcache_id_(0),
worker_document_set_(new WorkerDocumentSet()),
- resource_context_(resource_context) {
+ resource_context_(resource_context),
+ partition_(partition) {
DCHECK(resource_context_);
}
@@ -617,6 +622,7 @@ WorkerProcessHost::WorkerInstance::~WorkerInstance() {
bool WorkerProcessHost::WorkerInstance::Matches(
const GURL& match_url,
const string16& match_name,
+ const WorkerStoragePartition& partition,
content::ResourceContext* resource_context) const {
// Only match open shared workers.
if (closed_)
@@ -627,6 +633,11 @@ bool WorkerProcessHost::WorkerInstance::Matches(
if (resource_context_ != resource_context)
return false;
+ // We must be in the same storage partition otherwise sharing will violate
+ // isolation.
+ if (!partition_.Equals(partition))
+ return false;
+
if (url_.GetOrigin() != match_url.GetOrigin())
return false;
« no previous file with comments | « content/browser/worker_host/worker_process_host.h ('k') | content/browser/worker_host/worker_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698