Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2239)

Unified Diff: content/renderer/render_view_impl.cc

Issue 10885004: Implement disambiguation popup (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase, change event.boundingBox to event.data.tap Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/renderer/render_view_impl.h ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index cfc6fbc7f24827df635f5ab2ffceb6cd388be51b..8090f726a9c5a5174a3439f954cc64105171c14e 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -67,6 +67,7 @@
#include "content/renderer/browser_plugin/old/guest_to_embedder_channel.h"
#include "content/renderer/device_orientation_dispatcher.h"
#include "content/renderer/devtools_agent.h"
+#include "content/renderer/disambiguation_popup_helper.h"
#include "content/renderer/dom_automation_controller.h"
#include "content/renderer/dom_storage/webstoragenamespace_impl.h"
#include "content/renderer/do_not_track_bindings.h"
@@ -1057,6 +1058,8 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_SetWindowVisibility, OnSetWindowVisibility)
IPC_MESSAGE_HANDLER(ViewMsg_WindowFrameChanged, OnWindowFrameChanged)
#endif
+ IPC_MESSAGE_HANDLER(ViewMsg_ReleaseDisambiguationPopupDIB,
+ OnReleaseDisambiguationPopupDIB)
// Have the super handle all other messages.
IPC_MESSAGE_UNHANDLED(handled = RenderWidget::OnMessageReceived(message))
@@ -6285,3 +6288,45 @@ void RenderViewImpl::OnUpdatedFrameTree(
updating_frame_tree_ = false;
}
+
+bool RenderViewImpl::didTapMultipleTargets(
+ const WebKit::WebGestureEvent& event,
+ const WebVector<WebRect>& target_rects) {
+ gfx::Rect finger_rect = gfx::Rect(
darin (slow to review) 2012/10/08 21:03:46 no need to call the constructor and the copy const
trchen 2012/10/11 23:54:05 Done.
+ event.x - event.data.tap.width / 2, event.y - event.data.tap.height / 2,
+ event.data.tap.width, event.data.tap.height);
+ gfx::Rect zoom_rect;
+ float scale = DisambiguationPopupHelper::ComputeZoomAreaAndScaleFactor(
+ finger_rect, target_rects, GetSize(), &zoom_rect);
+ if (!scale)
+ return false;
+
+ gfx::Size canvas_size = zoom_rect.size();
+ canvas_size = canvas_size.Scale(scale);
+ TransportDIB* transport_dib = NULL;
+ {
+ scoped_ptr<skia::PlatformCanvas> canvas(
+ RenderProcess::current()->GetDrawingCanvas(&transport_dib,
+ gfx::Rect(canvas_size)));
+ if (!canvas.get())
+ return false;
+
+ canvas->scale(scale, scale);
+
+ canvas->translate(-zoom_rect.x(), -zoom_rect.y());
+ webwidget_->paint(webkit_glue::ToWebCanvas(canvas.get()), zoom_rect,
+ WebWidget::ForceSoftwareRenderingAndIgnoreGPUResidentContent);
+ }
+ Send(new ViewHostMsg_ShowDisambiguationPopup(routing_id_,
+ zoom_rect,
+ canvas_size,
+ transport_dib->id()));
+
+ return true;
+}
+
+void RenderViewImpl::OnReleaseDisambiguationPopupDIB(
+ TransportDIB::Handle dib_handle) {
+ TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
+ RenderProcess::current()->ReleaseTransportDIB(dib);
+}
« content/renderer/render_view_impl.h ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698