Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 10885004: Implement disambiguation popup (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase, change event.boundingBox to event.data.tap Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index e5aaac8a5a32c04487929365a0dbf750c1b588be..697b363c4f7ed0c51bfecc4184822ada7eddbd07 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -308,6 +308,8 @@ bool RenderWidgetHostImpl::OnMessageReceived(const IPC::Message &msg) {
OnMsgDidActivateAcceleratedCompositing)
IPC_MESSAGE_HANDLER(ViewHostMsg_LockMouse, OnMsgLockMouse)
IPC_MESSAGE_HANDLER(ViewHostMsg_UnlockMouse, OnMsgUnlockMouse)
+ IPC_MESSAGE_HANDLER(ViewHostMsg_ShowDisambiguationPopup,
+ OnMsgShowDisambiguationPopup)
#if defined(OS_POSIX) || defined(USE_AURA)
IPC_MESSAGE_HANDLER(ViewHostMsg_GetWindowRect, OnMsgGetWindowRect)
IPC_MESSAGE_HANDLER(ViewHostMsg_GetRootWindowRect, OnMsgGetRootWindowRect)
@@ -1722,6 +1724,19 @@ void RenderWidgetHostImpl::OnMsgDidActivateAcceleratedCompositing(
view_->OnAcceleratedCompositingStateChange();
}
+void RenderWidgetHostImpl::OnMsgShowDisambiguationPopup(
darin (slow to review) 2012/10/08 21:03:46 nit: please list this after OnMsgUnlockMouse so th
trchen 2012/10/11 23:54:05 Done.
+ const gfx::Rect& rect,
+ const gfx::Size& size,
+ const TransportDIB::Id& id) {
+ TransportDIB* dib = process_->GetTransportDIB(id);
+
+ // TODO(trchen): implement the platform-specific disambiguation popup
+ NOTIMPLEMENTED();
+
+ Send(new ViewMsg_ReleaseDisambiguationPopupDIB(GetRoutingID(),
+ dib->handle()));
+}
+
void RenderWidgetHostImpl::OnMsgLockMouse(bool user_gesture,
bool last_unlocked_by_target,
bool privileged) {

Powered by Google App Engine
This is Rietveld 408576698