Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 10885004: Implement disambiguation popup (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index d30948183c6a35459ec47d4e249f9d7ca3fea4f9..4089296485319be18d5d518ad44b97e0a527bb9e 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -302,6 +302,8 @@ bool RenderWidgetHostImpl::OnMessageReceived(const IPC::Message &msg) {
OnMsgDidActivateAcceleratedCompositing)
IPC_MESSAGE_HANDLER(ViewHostMsg_LockMouse, OnMsgLockMouse)
IPC_MESSAGE_HANDLER(ViewHostMsg_UnlockMouse, OnMsgUnlockMouse)
+ IPC_MESSAGE_HANDLER(ViewHostMsg_MultipleTargetsTouched,
+ OnMsgMultipleTargetsTouched)
#if defined(OS_POSIX) || defined(USE_AURA)
IPC_MESSAGE_HANDLER(ViewHostMsg_GetWindowRect, OnMsgGetWindowRect)
IPC_MESSAGE_HANDLER(ViewHostMsg_GetRootWindowRect, OnMsgGetRootWindowRect)
@@ -1706,6 +1708,19 @@ void RenderWidgetHostImpl::OnMsgDidActivateAcceleratedCompositing(
view_->OnAcceleratedCompositingStateChange();
}
+void RenderWidgetHostImpl::OnMsgMultipleTargetsTouched(
+ const gfx::Rect& rect,
+ const gfx::Size& size,
+ const TransportDIB::Id& id) {
+ TransportDIB* dib = process_->GetTransportDIB(id);
+
+// TODO: implement the platform-specific disambiguation popup
darin (slow to review) 2012/08/30 17:39:23 nit: indent by 2 spaces
trchen 2012/08/30 21:15:22 Done.
+ NOTIMPLEMENTED();
+
+ Send(new ViewMsg_ReleaseDisambiguationPopupDIB(GetRoutingID(),
+ dib->handle()));
+}
+
void RenderWidgetHostImpl::OnMsgLockMouse(bool user_gesture,
bool last_unlocked_by_target,
bool privileged) {

Powered by Google App Engine
This is Rietveld 408576698