Added restore functionality for maximize full/left/right

ash/wm/custom_frame_view_ash_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/custom_frame_view_ash.h"
 
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/wm/maximize_bubble_controller.h"
 #include "ash/wm/window_util.h"
 #include "ash/wm/workspace/frame_maximize_button.h"
 #include "ash/wm/workspace/snap_sizer.h"
 #include "base/command_line.h"
 #include "ui/aura/aura_switches.h"
+#include "ui/aura/client/aura_constants.h"
 #include "ui/aura/focus_manager.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #include "ui/base/gestures/gesture_configuration.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/test/test_views_delegate.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 
@@ skipping 451 matching lines @@
 
   // Pressing then additionally the left button shouldn't activate either.
   generator.PressLeftButton();
   RunAllPendingInMessageLoop();
   EXPECT_FALSE(maximize_button->is_snap_enabled());
   generator.ReleaseRightButton();
   generator.ReleaseLeftButton();
   EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
 }
 
+void ClickMaxButton(ash::FrameMaximizeButton* maximize_button,

[sky, 2012/08/27 22:18:16]

Wrap maximize_button to next line so that it lines up with other params. Also,
add a description.

[Mr4D (OOO till 08-26), 2012/08/28 01:30:25]

Done.

+    aura::Window* window,
+    SnapType snap_type) {
+  gfx::Point button_pos = maximize_button->GetBoundsInScreen().CenterPoint();
+  gfx::Point off_pos(button_pos.x() + 100, button_pos.y() + 100);
+
+  aura::test::EventGenerator generator(window->GetRootWindow(), off_pos);
+  generator.MoveMouseTo(off_pos);
+  EXPECT_FALSE(maximize_button->maximizer());
+  EXPECT_FALSE(maximize_button->phantom_window_open());
+
+  // Move the mouse cursor over the button.
+  generator.MoveMouseTo(button_pos);
+  EXPECT_TRUE(maximize_button->maximizer());
+  EXPECT_FALSE(maximize_button->phantom_window_open());
+
+  if (snap_type != SNAP_NONE) {
+    gfx::Point left_max_pos = maximize_button->maximizer()->
+        GetButtonForUnitTest(snap_type)->GetBoundsInScreen().CenterPoint();
+    generator.MoveMouseTo(left_max_pos);
+    EXPECT_TRUE(maximize_button->phantom_window_open());
+  }
+  // After pressing the left button the button should get triggered.
+  generator.ClickLeftButton();
+  EXPECT_FALSE(maximize_button->maximizer());
+}
+
+// Test that the restore from left/right maximize is properly done.
+TEST_F(CustomFrameViewAshTest, MaximizeLeftRestore) {
+  views::Widget* widget = CreateWidget();
+  aura::Window* window = widget->GetNativeWindow();
+  widget->SetBounds(gfx::Rect(10, 10, 100, 100));
+  gfx::Rect initial_bounds = widget->GetWindowBoundsInScreen();
+  CustomFrameViewAsh* frame = custom_frame_view_ash(widget);
+  CustomFrameViewAsh::TestApi test(frame);
+  ash::FrameMaximizeButton* maximize_button = test.maximize_button();
+  maximize_button->set_bubble_appearance_delay_ms(0);
+
+  ClickMaxButton(maximize_button, window, SNAP_LEFT);
+  RunAllPendingInMessageLoop();

[sky, 2012/08/27 22:18:16]

Why do you need to explicitly run the message loop here? At a minimum at a
comment.

[Mr4D (OOO till 08-26), 2012/08/28 01:30:25]

I have seen that other tests were doing this, so I was adding it as well.
Removed. Done.

+  // The window should not be maximized.
+  EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
+  // But the bounds should be different.
+  gfx::Rect new_bounds = widget->GetWindowBoundsInScreen();
+  EXPECT_EQ(0, new_bounds.x());
+  EXPECT_EQ(0, new_bounds.y());
+
+  // Now click the same button again to see that it restores.
+  ClickMaxButton(maximize_button, window, SNAP_LEFT);
+  RunAllPendingInMessageLoop();
+  // But the bounds should be restored.
+  new_bounds = widget->GetWindowBoundsInScreen();
+  EXPECT_EQ(new_bounds.x(), initial_bounds.x());
+  EXPECT_EQ(new_bounds.y(), initial_bounds.x());
+  EXPECT_EQ(new_bounds.width(), initial_bounds.width());
+  EXPECT_EQ(new_bounds.height(), initial_bounds.height());
+  // Make sure that there is no restore rectangle left.
+  EXPECT_EQ(NULL, window->GetProperty(aura::client::kRestoreBoundsKey));
+}
+
+// Maximize, left/right maximize and then restore should works.
+TEST_F(CustomFrameViewAshTest, MaximizeMaximizeLeftRestore) {
+  views::Widget* widget = CreateWidget();
+  aura::Window* window = widget->GetNativeWindow();
+  widget->SetBounds(gfx::Rect(10, 10, 100, 100));
+  gfx::Rect initial_bounds = widget->GetWindowBoundsInScreen();
+  CustomFrameViewAsh* frame = custom_frame_view_ash(widget);
+  CustomFrameViewAsh::TestApi test(frame);
+  ash::FrameMaximizeButton* maximize_button = test.maximize_button();
+  maximize_button->set_bubble_appearance_delay_ms(0);
+
+  ClickMaxButton(maximize_button, window, SNAP_NONE);
+  RunAllPendingInMessageLoop();
+  EXPECT_TRUE(ash::wm::IsWindowMaximized(window));
+
+  ClickMaxButton(maximize_button, window, SNAP_LEFT);
+  RunAllPendingInMessageLoop();
+  EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
+  gfx::Rect new_bounds = widget->GetWindowBoundsInScreen();
+  EXPECT_EQ(0, new_bounds.x());
+  EXPECT_EQ(0, new_bounds.y());
+
+  // Now click the same button again to see that it restores.
+  ClickMaxButton(maximize_button, window, SNAP_LEFT);
+  RunAllPendingInMessageLoop();
+  // But the bounds should be restored.
+  new_bounds = widget->GetWindowBoundsInScreen();
+  EXPECT_EQ(new_bounds.x(), initial_bounds.x());
+  EXPECT_EQ(new_bounds.y(), initial_bounds.x());
+  EXPECT_EQ(new_bounds.width(), initial_bounds.width());
+  EXPECT_EQ(new_bounds.height(), initial_bounds.height());
+  // Make sure that there is no restore rectangle left.
+  EXPECT_EQ(NULL, window->GetProperty(aura::client::kRestoreBoundsKey));
+}
+
+// Left/right maximize, maximize and then restore should work.
+TEST_F(CustomFrameViewAshTest, MaximizeLeftMaximizeRestore) {
+  views::Widget* widget = CreateWidget();
+  aura::Window* window = widget->GetNativeWindow();
+  widget->SetBounds(gfx::Rect(10, 10, 100, 100));
+  gfx::Rect initial_bounds = widget->GetWindowBoundsInScreen();
+  CustomFrameViewAsh* frame = custom_frame_view_ash(widget);
+  CustomFrameViewAsh::TestApi test(frame);
+  ash::FrameMaximizeButton* maximize_button = test.maximize_button();
+  maximize_button->set_bubble_appearance_delay_ms(0);
+
+  ClickMaxButton(maximize_button, window, SNAP_LEFT);
+  RunAllPendingInMessageLoop();
+  EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
+
+  ClickMaxButton(maximize_button, window, SNAP_NONE);
+  RunAllPendingInMessageLoop();
+  EXPECT_TRUE(ash::wm::IsWindowMaximized(window));
+
+  ClickMaxButton(maximize_button, window, SNAP_NONE);
+  RunAllPendingInMessageLoop();
+  EXPECT_FALSE(ash::wm::IsWindowMaximized(window));
+  gfx::Rect new_bounds = widget->GetWindowBoundsInScreen();
+  EXPECT_EQ(new_bounds.x(), initial_bounds.x());
+  EXPECT_EQ(new_bounds.y(), initial_bounds.x());
+  EXPECT_EQ(new_bounds.width(), initial_bounds.width());
+  EXPECT_EQ(new_bounds.height(), initial_bounds.height());
+  // Make sure that there is no restore rectangle left.
+  EXPECT_EQ(NULL, window->GetProperty(aura::client::kRestoreBoundsKey));
+}
+
 }  // namespace internal
 }  // namespace ash