Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 10883041: Add ash notification button resources (Closed)

Created:
8 years, 4 months ago by stevenjb
Modified:
8 years, 3 months ago
Reviewers:
jennyz
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Add ash notification button resources Resources for http://codereview.chromium.org/10878068/ BUG=144723 TBR=oshima

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-12 lines, --12 lines) Patch
A ui/resources/default_100_percent/ash/notification_button_active_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/ash/notification_button_active_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/ash/notification_button_active_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/ash/notification_button_inactive_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/ash/notification_button_inactive_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/ash/notification_button_inactive_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/notification_button_active_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/notification_button_active_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/notification_button_active_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/notification_button_inactive_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/notification_button_inactive_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/ash/notification_button_inactive_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jennyz
lgtm
8 years, 3 months ago (2012-08-27 22:50:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10883041/1
8 years, 3 months ago (2012-08-27 23:05:26 UTC) #2
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 23:05:30 UTC) #3
Presubmit check for 10883041-1 failed and returned exit status 1.


Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1258, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1106, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1023, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 43, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/ui/resources/resource_check/resource_scale_factors.py",
line 83, in RunChecks
    base_width, base_height = ImageSize(base_image)
  File
"/b/commit-queue/workdir/chromium/ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

Powered by Google App Engine
This is Rietveld 408576698