remoting/host/installer/linux/build-deb.sh - Issue 10882070: Simplify regex matching in build-deb.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/installer/linux/build-deb.sh

Issue 10882070: Simplify regex matching in build-deb.sh. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/installer/linux/build-deb.sh

diff --git a/remoting/host/installer/linux/build-deb.sh b/remoting/host/installer/linux/build-deb.sh

index 14231cb3e32e17a1a8c326c0e4cbe448bb99205f..3566b143dceb28aaddb8c7a843f9f3af05e55145 100755

--- a/remoting/host/installer/linux/build-deb.sh

+++ b/remoting/host/installer/linux/build-deb.sh

@@ -14,8 +14,7 @@ if [[ -z "$version_full" ]]; then

version_full="$version_base.$version_build"

-if !(echo $version_full | grep -E \

- "^[[:digit:]]+.[[:digit:]]+.[[:digit:]]+.[[:digit:]]+$" > /dev/null); then

+if [[ ! $version_full =~ ^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ ]]; then

Jamie 2012/08/27 22:39:54 You should add quotes around "$version_full"

Sergey Ulanov 2012/08/27 23:29:04 Done.

echo "Error: Invalid \$version_full value: $version_full" >&2

exit 1

« no previous file with comments | « no previous file | no next file » | no next file with comments »