Slightly modified ETA computation algorithm. Also modified UI of the

Slightly modified ETA computation algorithm. Also modified UI of the
update screen --- added labels for "Preparing...", "Verifying..." and
"Finalizing" stages.

BUG=143316
TEST=Manual testing on Alex device


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153485

[ygorshenin1, 2012-08-23 18:27:29]

Screenshots: file:///home/ygorshenin/www/oobe-update-screen/

[Ivan Korotkov, 2012-08-24 09:01:36]

lgtm

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/update_screen.cc (right):

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen.cc:53: const double
kDownloadSpeedSmoothFactor = 0.1;
Please comment what that means.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/update_screen_actor.h (right):

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen_actor.h:14: enum ProgressMessage {
Add a comment, please.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen_actor.h:16:
PROGRESS_MESSAGE_INSTALLING_UPDATE = 1,
No need in explicit numbers other than 0.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen_actor.h:54: // Shows message under
progress bar.
Show and enable have somewhat different meanings. Maybe 'bool visible'?

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
File chrome/browser/resources/chromeos/login/oobe.js (right):

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:161: * @param {boolean} enable
Are time left status show?
Please fix this sentence

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:165:
$('progress-message').hidden = true;
Is it ok that a further call with enable=false won't hide it?

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:195: * @param {boolean} enable
Are message should be shown?
ditto

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:198: if (enable)
ditto

[ygorshenin1, 2012-08-27 12:54:16]

Thanks!

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/update_screen.cc (right):

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen.cc:53: const double
kDownloadSpeedSmoothFactor = 0.1;
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> Please comment what that means.

Done.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/update_screen_actor.h (right):

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen_actor.h:14: enum ProgressMessage {
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> Add a comment, please.

Done.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen_actor.h:16:
PROGRESS_MESSAGE_INSTALLING_UPDATE = 1,
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> No need in explicit numbers other than 0.

Done.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/update_screen_actor.h:54: // Shows message under
progress bar.
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> Show and enable have somewhat different meanings. Maybe 'bool visible'?

Done.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
File chrome/browser/resources/chromeos/login/oobe.js (right):

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:161: * @param {boolean} enable
Are time left status show?
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> Please fix this sentence

Done.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:165:
$('progress-message').hidden = true;
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> Is it ok that a further call with enable=false won't hide it?

Done.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:195: * @param {boolean} enable
Are message should be shown?
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> ditto

Done.

http://codereview.chromium.org/10882014/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/login/oobe.js:198: if (enable)
On 2012/08/24 09:01:36, Ivan Korotkov wrote:
> ditto

Done.

[commit-bot: I haz the power, 2012-08-27 12:54:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/10882014/7002

[commit-bot: I haz the power, 2012-08-27 15:19:09]

Change committed as 153485