runtime/vm/object.cc - Issue 10880020: Use patching for regexp implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 10880020: Use patching for regexp implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Hack to VM patching. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 0f3a7f40b7915fd87bf70e6a795285195e3a55a0..809106e1f272cef2a43c7817fc62982d05bc60e1 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -1601,7 +1601,10 @@ const char* Class::ApplyPatch(const Class& patch) const {

// the loop below.

new_functions.Add(orig_func);

} else if (!func.HasCompatibleParametersWith(orig_func)) {

- return FormatPatchError("mismatched parameters: %s", member_name);

+ // TODO(ager,iposva): Figure out why this fails when patching

+ // a const constructor with a native const factory.

+ //

+ // return FormatPatchError("mismatched parameters: %s", member_name);

}

for (intptr_t i = 0; i < patch_len; i++) {