remoting/client/chromoting_client.cc - Issue 10879085: Cleanup RectangleUpdateDecoder and VideoStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/chromoting_client.cc

Issue 10879085: Cleanup RectangleUpdateDecoder and VideoStub (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/chromoting_client.cc

diff --git a/remoting/client/chromoting_client.cc b/remoting/client/chromoting_client.cc

index 3bdc7b6bb33ff896da8f79c48c948b8c4de5b7dd..1d2773d50e00d3433e78151ad6a8e437ed7c46e5 100644

--- a/remoting/client/chromoting_client.cc

+++ b/remoting/client/chromoting_client.cc

@@ -67,8 +67,9 @@ void ChromotingClient::Start(

void ChromotingClient::Stop(const base::Closure& shutdown_task) {

DCHECK(task_runner_->BelongsToCurrentThread());

- // Drop all pending packets.

- rectangle_decoder_->DropAllPackets();

+ // Stop decoder so we don't waste CPU cycles decoding video packets we will

+ // never show.

+ rectangle_decoder_->Stop();

connection_->Disconnect(base::Bind(&ChromotingClient::OnDisconnected,

weak_ptr_, shutdown_task));