Cleanup RectangleUpdateDecoder and VideoStub

remoting/protocol/video_stub.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_VIDEO_STUB_H_
 #define REMOTING_PROTOCOL_VIDEO_STUB_H_
 
 #include "base/callback_forward.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace remoting {
 
 class VideoPacket;
 
 namespace protocol {
 
 class VideoStub {
  public:
   virtual ~VideoStub() { }
 
   // TODO(sergeyu): VideoPacket is the protobuf message that is used to send
   // video packets in protobuf stream. It should not be used here. Add another
   // struct and use it to represent video packets internally.

[Wez, 2012/08/28 16:42:27]

nit: Remove this comment; the stubs are defined in the protocol layer right now,
and even if they weren't, they'd be in a higher layer that can reasonably depend
on the protocol layer. Protobufs already abstract sufficiently from the
on-the-wire layout that it's not worth the extra layer of abstraction.

[Sergey Ulanov, 2012/08/28 18:30:27]

Done.

   virtual void ProcessVideoPacket(scoped_ptr<VideoPacket> video_packet,
                                   const base::Closure& done) = 0;
 
-  // Returns number of packets currently pending in the buffer.
-  virtual int GetPendingVideoPackets() = 0;
-
  protected:
   VideoStub() { }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(VideoStub);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_VIDEO_STUB_H_