Cleanup RectangleUpdateDecoder and VideoStub

remoting/client/chromoting_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/chromoting_client.h"
 
 #include "base/bind.h"
 #include "remoting/client/audio_decode_scheduler.h"
 #include "remoting/client/audio_player.h"
 #include "remoting/client/client_context.h"
@@ skipping 49 matching lines @@
   connection_->Connect(xmpp_proxy, config_.local_jid, config_.host_jid,
                        config_.host_public_key, transport_factory.Pass(),
                        authenticator.Pass(), this, this, this,
                        rectangle_decoder_,
                        audio_decode_scheduler_.get());
 }
 
 void ChromotingClient::Stop(const base::Closure& shutdown_task) {
   DCHECK(task_runner_->BelongsToCurrentThread());
 
-  // Drop all pending packets.
-  rectangle_decoder_->DropAllPackets();
+  // Stop decoder so we don't waste CPU cycles decoding video packets we will
+  // never show.
+  rectangle_decoder_->Stop();
 
   connection_->Disconnect(base::Bind(&ChromotingClient::OnDisconnected,
                                      weak_ptr_, shutdown_task));
 }
 
 void ChromotingClient::OnDisconnected(const base::Closure& shutdown_task) {
   shutdown_task.Run();
 }
 
 ChromotingStats* ChromotingClient::GetStats() {
@@ skipping 30 matching lines @@
 void ChromotingClient::Initialize() {
   DCHECK(task_runner_->BelongsToCurrentThread());
 
   // Initialize the decoder.
   rectangle_decoder_->Initialize(connection_->config());
   if (connection_->config().is_audio_enabled())
     audio_decode_scheduler_->Initialize(connection_->config());
 }
 
 }  // namespace remoting