Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 10879069: Enable RenderText path in print_web_view_helper.cc on the Mac. (Closed)

Created:
8 years, 3 months ago by Alexei Svitkine (slow)
Modified:
8 years, 3 months ago
Reviewers:
Nico, kmadhusu
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, arthurhsu
Visibility:
Public.

Description

Enable RenderText path in print_web_view_helper.cc on the Mac. BUG=137033 TEST=Go to ko.wikipedia.org and bring up the print preview dialog. Korean characters in header and footer text should not show up as boxes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexei Svitkine (slow)
8 years, 3 months ago (2012-08-28 13:15:43 UTC) #1
kmadhusu
lgtm
8 years, 3 months ago (2012-08-28 16:18:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10879069/1
8 years, 3 months ago (2012-08-28 16:45:40 UTC) #3
commit-bot: I haz the power
Presubmit check for 10879069-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-28 16:45:46 UTC) #4
Alexei Svitkine (slow)
Nico, could I get an OWNERS approval for chrome/?
8 years, 3 months ago (2012-08-28 16:56:03 UTC) #5
Nico
lgtm
8 years, 3 months ago (2012-08-28 17:00:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10879069/1
8 years, 3 months ago (2012-08-28 17:01:08 UTC) #7
commit-bot: I haz the power
Try job failure for 10879069-1 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-28 20:33:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10879069/1
8 years, 3 months ago (2012-08-28 20:34:45 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 23:26:25 UTC) #10
Change committed as 153785

Powered by Google App Engine
This is Rietveld 408576698