Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: runtime/vm/compiler.cc

Issue 10879041: Validate well-formedness of the use lists in debug mode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index 10183565a9362c01cb6335fa0c489dd0f55e180c..56717e0e20702bb34512805dec63c2de08f3ac09 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -193,9 +193,8 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
FlowGraphTypePropagator propagator(*flow_graph);
propagator.PropagateTypes();
- // TODO(zerny): Here we assume that the use lists remain valid after
- // type propagation. We should construct a use-list validator to make
- // this explicit in DEBUG mode.
+ // Verify that the use lists are still valid.
+ DEBUG_ASSERT(flow_graph->ValidateUseLists());
// Do optimizations that depend on the propagated type information.
optimizer.OptimizeComputations();
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698