Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10879010: Add named constants for all type codes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 2761f9df0fc6b414aec9dabf2d64cbf114bc9cae..97b28aeb425123ff80b3a4c70ff196aef30eae6e 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -1493,8 +1493,8 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
visitInvokeStatic(HInvokeStatic node) {
if (Elements.isStaticOrTopLevelFunction(node.element) &&
ngeoffray 2012/08/22 14:21:07 Why this check? Why aren't we unconditionally regi
Søren Gjesse 2012/08/23 07:02:04 Good question. Removed.
- (node.typeCode() == HInvokeStatic.INVOKE_STATIC_TYPECODE ||
- node.typeCode() == HInvokeStatic.INVOKE_INTERCEPTOR_TYPECODE)) {
+ (node.typeCode() == HInstruction.INVOKE_STATIC_TYPECODE ||
+ node.typeCode() == HInstruction.INVOKE_INTERCEPTOR_TYPECODE)) {
// Register this invocation to collect the types used at all call sites.
backend.registerStaticInvocation(node, types);
}
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698