net: Move file operation code from UploadData to UploadDataStream

content/browser/renderer_host/resource_dispatcher_host_impl.cc

Index: content/browser/renderer_host/resource_dispatcher_host_impl.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host_impl.cc b/content/browser/renderer_host/resource_dispatcher_host_impl.cc
index 205993824612efaa6fe85cfdb8091d4e62305292..bf78554b7db0f3f491820875e6982a2ee5b4fa00 100644
--- a/content/browser/renderer_host/resource_dispatcher_host_impl.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host_impl.cc
@@ -69,7 +69,7 @@
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/base/request_priority.h"
 #include "net/base/ssl_cert_request_info.h"
-#include "net/base/upload_data.h"
+#include "net/base/upload_data_stream.h"
 #include "net/cookies/cookie_monster.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_response_headers.h"
@@ -965,7 +965,9 @@ void ResourceDispatcherHostImpl::BeginRequest(
             GetBlobStorageControllerForResourceContext(resource_context)));
     // This results in performing file IO. crbug.com/112607.
     base::ThreadRestrictions::ScopedAllowIO allow_io;
-    upload_size = request->get_upload_mutable()->GetContentLengthSync();
+    net::UploadDataStream upload_stream(request->get_upload_mutable());
+    if (upload_stream.Init() == net::OK)

[willchan no longer on Chromium, 2012/08/28 23:45:22]

I'm concerned about calling Init() here. Doesn't that have side effects? Do we
really want to be doing that all the time? It looks like it resets the offsets
in the elements. I guess that's fine here, but in the webkit
SimpleResourceLoaderBridge where we're just getting upload progress, isn't
resetting offsets wrong?

[hashimoto, 2012/08/28 23:49:56]

You're right.  Resetting offsets here is wrong.
We can get rid of this code once GetUploadProgress starts returning the upload
size (http://codereview.chromium.org/10825073/ is still waiting for darin's
review)
Let's submit this change after that.

While waiting for darin's review, could you take a look at other parts?
Thanks,

[willchan no longer on Chromium, 2012/08/28 23:59:36]

I read everything else already. That was my only concern.

+      upload_size = upload_stream.size();
   }
 
   bool allow_download = request_data.allow_download &&