Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sandbox/win/src/target_process.h

Issue 10878071: Move STARTUPINFO manipulation into SpawnTarget (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sandbox/win/src/broker_services.cc ('K') | « sandbox/win/src/broker_services.cc ('k') | sandbox/win/src/target_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/target_process.h
===================================================================
--- sandbox/win/src/target_process.h (revision 153000)
+++ sandbox/win/src/target_process.h (working copy)
@@ -11,6 +11,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/win/scoped_handle.h"
#include "base/win/scoped_process_information.h"
+#include "base/win/startup_information.h"
rvargas (doing something else) 2012/08/27 17:56:22 nit: forward declare
jschuh 2012/08/27 19:10:19 Done.
#include "sandbox/win/src/crosscall_server.h"
#include "sandbox/win/src/sandbox_types.h"
@@ -38,7 +39,7 @@
// Creates the new target process. The process is created suspended.
DWORD Create(const wchar_t* exe_path,
const wchar_t* command_line,
- const wchar_t* desktop,
+ base::win::StartupInformation* startup_info,
rvargas (doing something else) 2012/08/27 17:56:22 const SI& (preferred)? or const SI*
jschuh 2012/08/27 19:10:19 Done.
base::win::ScopedProcessInformation* target_info);
// Destroys the target process.
« sandbox/win/src/broker_services.cc ('K') | « sandbox/win/src/broker_services.cc ('k') | sandbox/win/src/target_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698