Move STARTUPINFO manipulation into SpawnTarget

sandbox/win/src/target_process.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SANDBOX_SRC_TARGET_PROCESS_H__
 #define SANDBOX_SRC_TARGET_PROCESS_H__
 
 #include <windows.h>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/win/scoped_handle.h"
 #include "base/win/scoped_process_information.h"
+#include "base/win/startup_information.h"

[rvargas (doing something else), 2012/08/27 17:56:22]

nit: forward declare

[jschuh, 2012/08/27 19:10:19]

Done.

 #include "sandbox/win/src/crosscall_server.h"
 #include "sandbox/win/src/sandbox_types.h"
 
 namespace sandbox {
 
 class SharedMemIPCServer;
 class ThreadProvider;
 
 // TargetProcess models a target instance (child process). Objects of this
 // class are owned by the Policy used to create them.
 class TargetProcess {
  public:
   // The constructor takes ownership of |initial_token| and |lockdown_token|.
   TargetProcess(HANDLE initial_token, HANDLE lockdown_token, HANDLE job,
                 ThreadProvider* thread_pool);
   ~TargetProcess();
 
   // TODO(cpu): Currently there does not seem to be a reason to implement
   // reference counting for this class since is internal, but kept the
   // the same interface so the interception framework does not need to be
   // touched at this point.
   void AddRef() {}
   void Release() {}
 
   // Creates the new target process. The process is created suspended.
   DWORD Create(const wchar_t* exe_path,
                const wchar_t* command_line,
-               const wchar_t* desktop,
+               base::win::StartupInformation* startup_info,

[rvargas (doing something else), 2012/08/27 17:56:22]

const SI& (preferred)? or const SI*

[jschuh, 2012/08/27 19:10:19]

Done.

                base::win::ScopedProcessInformation* target_info);
 
   // Destroys the target process.
   void Terminate();
 
   // Creates the IPC objects such as the BrokerDispatcher and the
   // IPC server. The IPC server uses the services of the thread_pool.
   DWORD Init(Dispatcher* ipc_dispatcher, void* policy,
              uint32 shared_IPC_size, uint32 shared_policy_size);
 
@@ skipping 61 matching lines @@
 };
 
 // Creates a mock TargetProcess used for testing interceptions.
 // TODO(cpu): It seems that this method is not going to be used anymore.
 TargetProcess* MakeTestTargetProcess(HANDLE process, HMODULE base_address);
 
 
 }  // namespace sandbox
 
 #endif  // SANDBOX_SRC_TARGET_PROCESS_H__