Issue 10878068: Replace Ash web notification tray view with a button.

Issue 10878068: Replace Ash web notification tray view with a button. (Closed)

Created:
8 years, 4 months ago by stevenjb

Modified:
8 years, 3 months ago

Reviewers:
jennyz

CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace Ash web notification tray view with a button. Resource files are in http://codereview.chromium.org/10883041/ BUG=144723

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -43 lines)			Patch
M	ash/system/tray/system_tray.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/tray/tray_background_view.h	View	2 chunks	+5 lines, -3 lines	1 comment	Download
M	ash/system/tray/tray_background_view.cc	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.h	View	5 chunks	+11 lines, -3 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.cc	View	10 chunks	+45 lines, -31 lines	0 comments	Download
M	ui/resources/ui_resources.grd	View	1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

I had time to go ahead and implement the new button icons for the web ...

8 years, 4 months ago (2012-08-25 00:52:49 UTC) #1

tfarina

https://chromiumcodereview.appspot.com/10878068/diff/1/ui/resources/ui_resources.grd File ui/resources/ui_resources.grd (right): https://chromiumcodereview.appspot.com/10878068/diff/1/ui/resources/ui_resources.grd#newcode159 ui/resources/ui_resources.grd:159: <structure type="chrome_scaled_image" name="IDR_AURA_UBER_TRAY_NOTIFY_BUTTON_ACTIVE_NORMAL" file="ash/notification_button_active_normal.png" /> looks like we need ...

8 years, 3 months ago (2012-08-26 22:17:17 UTC) #2

tfarina

https://chromiumcodereview.appspot.com/10878068/diff/1/ash/system/tray/tray_background_view.h File ash/system/tray/tray_background_view.h (right): https://chromiumcodereview.appspot.com/10878068/diff/1/ash/system/tray/tray_background_view.h#newcode60 ash/system/tray/tray_background_view.h:60: bool set_background); nit: fix indentation here.

8 years, 3 months ago (2012-08-26 22:17:59 UTC) #3

lgtm

Expand Messages | Collapse Messages