Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Side by Side Diff: ash/accelerators/accelerator_controller.cc

Issue 10878058: Move functions for controlling Caps Lock to CapsLockDelegate from SystemTrayDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comment Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_controller.h" 5 #include "ash/accelerators/accelerator_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <string> 9 #include <string>
10 10
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 shell->delegate()->RecordUserMetricsAction(UMA_ACCEL_SEARCH_LWIN); 470 shell->delegate()->RecordUserMetricsAction(UMA_ACCEL_SEARCH_LWIN);
471 // When spoken feedback is enabled, we should neither toggle the list nor 471 // When spoken feedback is enabled, we should neither toggle the list nor
472 // consume the key since Search+Shift is one of the shortcuts the a11y 472 // consume the key since Search+Shift is one of the shortcuts the a11y
473 // feature uses. crbug.com/132296 473 // feature uses. crbug.com/132296
474 DCHECK_EQ(ui::VKEY_LWIN, accelerator.key_code()); 474 DCHECK_EQ(ui::VKEY_LWIN, accelerator.key_code());
475 if (Shell::GetInstance()->delegate()->IsSpokenFeedbackEnabled()) 475 if (Shell::GetInstance()->delegate()->IsSpokenFeedbackEnabled())
476 return false; 476 return false;
477 ash::Shell::GetInstance()->ToggleAppList(); 477 ash::Shell::GetInstance()->ToggleAppList();
478 return true; 478 return true;
479 case DISABLE_CAPS_LOCK: 479 case DISABLE_CAPS_LOCK:
480 // TODO(mazda): Handle this using |caps_lock_delegate_|. 480 if (shell->caps_lock_delegate()->IsCapsLockEnabled())
481 if (shell->tray_delegate()->IsCapsLockOn()) 481 shell->caps_lock_delegate()->SetCapsLockEnabled(false);
482 shell->tray_delegate()->SetCapsLockEnabled(false);
483 return true; 482 return true;
484 case TOGGLE_CAPS_LOCK: 483 case TOGGLE_CAPS_LOCK:
485 if (caps_lock_delegate_.get()) 484 shell->caps_lock_delegate()->ToggleCapsLock();
486 return caps_lock_delegate_->HandleToggleCapsLock(); 485 return true;
487 break;
488 case BRIGHTNESS_DOWN: 486 case BRIGHTNESS_DOWN:
489 if (brightness_control_delegate_.get()) 487 if (brightness_control_delegate_.get())
490 return brightness_control_delegate_->HandleBrightnessDown(accelerator); 488 return brightness_control_delegate_->HandleBrightnessDown(accelerator);
491 break; 489 break;
492 case BRIGHTNESS_UP: 490 case BRIGHTNESS_UP:
493 if (brightness_control_delegate_.get()) 491 if (brightness_control_delegate_.get())
494 return brightness_control_delegate_->HandleBrightnessUp(accelerator); 492 return brightness_control_delegate_->HandleBrightnessUp(accelerator);
495 break; 493 break;
496 case KEYBOARD_BRIGHTNESS_DOWN: 494 case KEYBOARD_BRIGHTNESS_DOWN:
497 if (keyboard_brightness_control_delegate_.get()) 495 if (keyboard_brightness_control_delegate_.get())
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 NOTREACHED() << "Unhandled action " << action; 673 NOTREACHED() << "Unhandled action " << action;
676 } 674 }
677 return false; 675 return false;
678 } 676 }
679 677
680 void AcceleratorController::SetBrightnessControlDelegate( 678 void AcceleratorController::SetBrightnessControlDelegate(
681 scoped_ptr<BrightnessControlDelegate> brightness_control_delegate) { 679 scoped_ptr<BrightnessControlDelegate> brightness_control_delegate) {
682 brightness_control_delegate_.swap(brightness_control_delegate); 680 brightness_control_delegate_.swap(brightness_control_delegate);
683 } 681 }
684 682
685 void AcceleratorController::SetCapsLockDelegate(
686 scoped_ptr<CapsLockDelegate> caps_lock_delegate) {
687 caps_lock_delegate_.swap(caps_lock_delegate);
688 }
689
690 void AcceleratorController::SetImeControlDelegate( 683 void AcceleratorController::SetImeControlDelegate(
691 scoped_ptr<ImeControlDelegate> ime_control_delegate) { 684 scoped_ptr<ImeControlDelegate> ime_control_delegate) {
692 ime_control_delegate_.swap(ime_control_delegate); 685 ime_control_delegate_.swap(ime_control_delegate);
693 } 686 }
694 687
695 void AcceleratorController::SetKeyboardBrightnessControlDelegate( 688 void AcceleratorController::SetKeyboardBrightnessControlDelegate(
696 scoped_ptr<KeyboardBrightnessControlDelegate> 689 scoped_ptr<KeyboardBrightnessControlDelegate>
697 keyboard_brightness_control_delegate) { 690 keyboard_brightness_control_delegate) {
698 keyboard_brightness_control_delegate_.swap( 691 keyboard_brightness_control_delegate_.swap(
699 keyboard_brightness_control_delegate); 692 keyboard_brightness_control_delegate);
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 accelerators_.insert( 749 accelerators_.insert(
757 std::make_pair(accelerator, accelerators[i].action)); 750 std::make_pair(accelerator, accelerators[i].action));
758 } 751 }
759 } 752 }
760 753
761 bool AcceleratorController::CanHandleAccelerators() const { 754 bool AcceleratorController::CanHandleAccelerators() const {
762 return true; 755 return true;
763 } 756 }
764 757
765 } // namespace ash 758 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698