chrome/test/data/extensions/platform_apps/windows_api/test.js - Issue 10878040: Move context-sensitive app.window.* functions to app.window.current().*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/windows_api/test.js

Issue 10878040: Move context-sensitive app.window.* functions to app.window.current().* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/app_window_custom_bindings.js ('K') | « chrome/renderer/resources/extensions/app_window_custom_bindings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/windows_api/test.js

diff --git a/chrome/test/data/extensions/platform_apps/windows_api/test.js b/chrome/test/data/extensions/platform_apps/windows_api/test.js

index 86a4cf2e56e7127d887207c01eace4f158143d6d..ae324be084a31974006b1711a7b78425070d4f10 100644

--- a/chrome/test/data/extensions/platform_apps/windows_api/test.js

+++ b/chrome/test/data/extensions/platform_apps/windows_api/test.js

@@ -8,10 +8,10 @@ chrome.app.runtime.onLaunched.addListener(function() {

chrome.test.runTests([

function testCreateWindow() {

chrome.app.window.create('test.html', {}, callbackPass(function (win) {

- chrome.test.assertTrue(typeof win.window === 'object');

- chrome.test.assertEq('about:blank', win.location.href);

+ chrome.test.assertTrue(typeof win.dom.window === 'object');

+ chrome.test.assertEq('about:blank', win.dom.location.href);

chrome.test.assertEq('<html><head></head><body></body></html>',

- win.document.documentElement.outerHTML);

+ win.dom.document.documentElement.outerHTML);

}))

@@ -19,12 +19,12 @@ chrome.app.runtime.onLaunched.addListener(function() {

chrome.app.window.create('test.html',

{width:512, height:384, frame:'custom'},

callbackPass(function(win) {

- chrome.test.assertEq(512, win.innerWidth);

- chrome.test.assertEq(384, win.innerHeight);

- var oldWidth = win.outerWidth, oldHeight = win.outerHeight;

- win.resizeBy(-256, 0);

- chrome.test.assertEq(oldWidth - 256, win.outerWidth);

- chrome.test.assertEq(oldHeight, win.outerHeight);

+ chrome.test.assertEq(512, win.dom.innerWidth);

+ chrome.test.assertEq(384, win.dom.innerHeight);

+ var oldWidth = win.dom.outerWidth, oldHeight = win.dom.outerHeight;

+ win.dom.resizeBy(-256, 0);

+ chrome.test.assertEq(oldWidth - 256, win.dom.outerWidth);

+ chrome.test.assertEq(oldHeight, win.dom.outerHeight);

}));