chrome/common/extensions/extension.cc - Issue 10878040: Move context-sensitive app.window.* functions to app.window.current().*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10878040: Move context-sensitive app.window.* functions to app.window.current().* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/app_window.idl ('k') | chrome/common/extensions/permissions/api_permission.h » ('j') | chrome/renderer/resources/extensions/app_window_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 24916813fd73b5dca9f529017f34a0d27c1da2fa..a65b7a1a4cf10d099cf2eff614fed966d71c80dd 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -3134,6 +3134,7 @@ bool Extension::InitFromValue(int flags, string16* error) {

// app.window API to platform apps, with no dependency on any permissions.

// See http://crbug.com/120069.

if (is_platform_app()) {

+ api_permissions.insert(APIPermission::kAppCurrentWindowInternal);

api_permissions.insert(APIPermission::kAppRuntime);

api_permissions.insert(APIPermission::kAppWindow);

}