Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: sync/engine/download_updates_command.cc

Issue 10878015: [Sync] Move keystore key handling to SyncEncryptionHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/download_updates_command.cc
diff --git a/sync/engine/download_updates_command.cc b/sync/engine/download_updates_command.cc
index fb4c094277ca531be5a451338e86d95cca656fc9..f9f0367f9b17d36c130f8d5db1da4fc609d6bb90 100644
--- a/sync/engine/download_updates_command.cc
+++ b/sync/engine/download_updates_command.cc
@@ -11,8 +11,8 @@
#include "sync/engine/syncer_proto_util.h"
#include "sync/internal_api/public/base/model_type_payload_map.h"
#include "sync/syncable/directory.h"
+#include "sync/syncable/nigori_handler.h"
#include "sync/syncable/read_transaction.h"
-#include "sync/util/cryptographer.h"
using sync_pb::DebugInfo;
@@ -38,13 +38,14 @@ SyncerError HandleGetEncryptionKeyResponse(
return SERVER_RESPONSE_VALIDATION_FAILED;
}
syncable::ReadTransaction trans(FROM_HERE, dir);
- Cryptographer* cryptographer = dir->GetCryptographer(&trans);
- success = cryptographer->SetKeystoreKey(
- update_response.get_updates().encryption_key());
+ syncable::NigoriHandler* nigori_handler = dir->GetNigoriHandler();
+ success = nigori_handler->SetKeystoreKey(
+ update_response.get_updates().encryption_key(),
+ &trans);
DVLOG(1) << "GetUpdates returned encryption key of length "
<< update_response.get_updates().encryption_key().length()
- << ". Cryptographer keystore key "
+ << ". Nigori keystore key "
<< (success ? "" : "not ") << "updated.";
return (success ? SYNCER_OK : SERVER_RESPONSE_VALIDATION_FAILED);
}
@@ -91,9 +92,8 @@ SyncerError DownloadUpdatesCommand::ExecuteImpl(SyncSession* session) {
if (session->context()->keystore_encryption_enabled()) {
syncable::Directory* dir = session->context()->directory();
syncable::ReadTransaction trans(FROM_HERE, dir);
- Cryptographer* cryptographer =
- session->context()->directory()->GetCryptographer(&trans);
- need_encryption_key = !cryptographer->HasKeystoreKey();
+ syncable::NigoriHandler* nigori_handler = dir->GetNigoriHandler();
+ need_encryption_key = nigori_handler->NeedKeystoreKey(&trans);
get_updates->set_need_encryption_key(need_encryption_key);
}

Powered by Google App Engine
This is Rietveld 408576698