Rename GDataErrorCode to DriveErrorCode, GDataFileError to DriveFileError

Rename GDataErrorCode to DriveErrorCode, GDataFileError to DriveFileError

In this CL, folloing changes are contained:

* gdata_errocode.h has been renamed to drive_errocode.h
* enum GDataErrorCode has been renamed to DriveErrorCode
* enum GDataFileError has been renamed to DriveFileError
* error codes in GDataErrorCode and GDataFileError whose prefix is "GDATA_"
  have been renamed to "DRIVE_*"

BUG=137151
TEST=pass all existing tests
TBR=derat@chromium.org, abodenha@chromium.org, estade@chromium.org, satorux@chromium.org, ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153005

[kochi, 2012-08-22 16:07:03]

Hi Satoru,

Could you review this?

Thanks,

[satorux1, 2012-08-22 20:12:21]

http://codereview.chromium.org/10877006/diff/2001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_contacts_service.cc (right):

http://codereview.chromium.org/10877006/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:483: void
HandleGroupsFeedData(DriveErrorCode error,
Hmm... This does not look correct.

Contacts is nothing to deal with Drive.

I guess GDataErrorCode should be kept as before.

[Daniel Erat, 2012-08-22 20:18:40]

http://codereview.chromium.org/10877006/diff/2001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_contacts_service.cc (right):

http://codereview.chromium.org/10877006/diff/2001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_contacts_service.cc:483: void
HandleGroupsFeedData(DriveErrorCode error,
On 2012/08/22 20:12:21, satorux1 wrote:
> Hmm... This does not look correct.
> 
> Contacts is nothing to deal with Drive.
> 
> I guess GDataErrorCode should be kept as before.

Yeah, I think so too. :-(

[kochi, 2012-08-23 07:01:18]

Hi

Thanks for the review.
GDataErrorCode was a subtle point for refactoring, as
it currently serves GData specific error code but some of
them are shared with Drive V2 API - I will have to
refactor this error code again.

Reverted GDataErrorCode related changes and now only
contains s/GDataFileError/DriveFileError/g part.

Please take another look.

[kochi, 2012-08-23 09:56:11]

Kazuhiro, could you take a look at this CL for Satoru's absence?
Thanks,

On 2012/08/23 07:01:18, Takayoshi Kochi wrote:
> Hi
> 
> Thanks for the review.
> GDataErrorCode was a subtle point for refactoring, as
> it currently serves GData specific error code but some of
> them are shared with Drive V2 API - I will have to
> refactor this error code again.
> 
> Reverted GDataErrorCode related changes and now only
> contains s/GDataFileError/DriveFileError/g part.
> 
> Please take another look.

[kinaba, 2012-08-23 11:17:37]

lgtm

[commit-bot: I haz the power, 2012-08-23 16:07:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10877006/9001

[commit-bot: I haz the power, 2012-08-23 16:07:38]

Presubmit check for 10877006-9001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/chromeos/gdata/drive_cache.cc:757
    metadata_->ForceRescanForTesting(cache_paths_); \
  chrome/browser/chromeos/gdata/gdata_contacts_service.cc:481
    operation->set_feed_url_for_testing( \
  chrome/browser/chromeos/gdata/gdata_contacts_service.cc:590
    operation->set_feed_url_for_testing(

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/ash
    chrome/browser/ui/webui/print_preview
    chrome/browser/ui/webui
    chrome/browser/ui/webui/chromeos
    chrome/browser/chromeos/extensions

Presubmit checks took 10.0s to calculate.

[kochi, 2012-08-23 16:13:33]

Added TBR=,
Daniel, could you check c/b/ui/ash?
Albert, could you check c/b/ui/webui/print_preview?
Satoru, could you check c/b/ui/webui/chromeos and c/b/chromeos/extensions?
Evan, could you check chrome/browser/ui/webui?

[commit-bot: I haz the power, 2012-08-23 16:15:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10877006/9001

[Daniel Erat, 2012-08-23 16:15:38]

LGTM for ui/ash

It's fine to TBR people in OWNERS files for trivial changes like this one, by
the way.

[Albert Bodenhamer, 2012-08-23 16:17:23]

LGTM for print preview

[Ben Goodger (Google), 2012-08-23 19:54:53]

lgtm