Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: webkit/plugins/npapi/plugin_list.h

Issue 10876083: [4] Changing content_settings_api to use PluginFinder's async interface (Closed) Base URL: http://git.chromium.org/chromium/src.git@async_start
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/npapi/plugin_list.h
diff --git a/webkit/plugins/npapi/plugin_list.h b/webkit/plugins/npapi/plugin_list.h
index 57204892bb31492462e826a99d4b09828def4a86..3d6ba87ab88af47a9ba56f5a6c43d8c298327ea2 100644
--- a/webkit/plugins/npapi/plugin_list.h
+++ b/webkit/plugins/npapi/plugin_list.h
@@ -196,7 +196,11 @@ class WEBKIT_PLUGINS_EXPORT PluginList {
virtual ~PluginList();
protected:
- // TODO(ibraaaa): DELETE and add a different one. http://crbug.com/124396
+ // This constructor is used in unit tests to skip platform-dependent
+ // initialization.
+ PluginList(int dummy);
Mattias Nissler (ping if slow) 2012/08/27 15:42:09 Just use the constructor below instead, passing NU
ibraaaa 2012/08/27 17:34:05 The Ctor below is going to be deleted anyways and
+
+ // TODO(ibraaaa): DELETE. http://crbug.com/124396
// This constructor is used in unit tests to override the platform-dependent
// real-world plugin group definitions with custom ones.
PluginList(const PluginGroupDefinition* definitions, size_t num_definitions);

Powered by Google App Engine
This is Rietveld 408576698