Get fix_test_cases.py to run on Windows

tools/isolate/fix_test_cases.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Scripts to run a test, grab the failures and trace them."""
 
 import json
 import os
 import subprocess
@@ skipping 44 matching lines @@
 
   Assumes run_test_cases.py is implicitly called.
   """
   handle, result_file = tempfile.mkstemp(prefix='run_test_cases')
   os.close(handle)
   env = os.environ.copy()
   env['RUN_TEST_CASES_RESULT_FILE'] = result_file
   env['GTEST_SHARD_INDEX'] = str(shard_index)
   env['GTEST_TOTAL_SHARDS'] = str(shard_count)
   cmd = [sys.executable, 'isolate.py', 'run', '-r', result]
-  return_code = subprocess.call(cmd, env=env)
+  subprocess.call(cmd, env=env)
   if not os.path.isfile(result_file):
     print >> sys.stderr, 'Failed to find %s' % result_file
     return None
-  if return_code:
-    print >> sys.stderr, 'Failed to run isolate.py run'
-    return None
   with open(result_file) as f:
     try:
       data = json.load(f)
     except ValueError as e:
       print >> sys.stderr, ('Unable to load json file, %s: %s' %
                             (result_file, str(e)))
       return None
   os.remove(result_file)
   return [
     test for test, runs in data.iteritems()
@@ skipping 85 matching lines @@
 
 def main():
   parser = run_test_cases.OptionParserWithTestSharding(
       usage='%prog <option> [test]')
   options, args = parser.parse_args()
 
   if len(args) != 1:
     parser.error('Use with the name of the test only, e.g. "unit_tests"')
 
   basename = args[0]
-  executable = '../../out/Release/%s' % basename
+  if sys.platform == 'win32' or sys.platform == 'cygwin':

[M-A Ruel, 2012/08/27 14:21:51]

if sys.platform in ('cygwin', 'win32'):

[csharp, 2012/08/27 15:52:41]

Done.

+    executable = '../../build/Release/%s' % basename

[M-A Ruel, 2012/08/27 14:21:51]

Actually, that's kind of crappy, I'd rather remove the hard-coded path
completely as I tried to avoid these in general. I've been lousy on this script.

[csharp, 2012/08/27 15:52:41]

Done.

+  else:
+    executable = '../../out/Release/%s' % basename
   result = '%s.results' % executable
   if sys.platform == 'win32':

[M-A Ruel, 2012/08/27 15:31:09]

cygwin too. But I don't think tracing works.

[csharp, 2012/08/27 15:52:41]

Done.

     executable += '.exe'
   if not os.path.isfile(executable):
     print >> sys.stderr, (
         '%s doesn\'t exist, please build %s_run' % (executable, basename))
     return 1
   if not os.path.isfile(result):
     print >> sys.stderr, (
         '%s doesn\'t exist, please build %s_run' % (result, basename))
     return 1
 
   return not fix_all(result, options.index, options.shards)
 
 
 if __name__ == '__main__':
   sys.exit(main())