chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h - Issue 10876041: Polish the SystemInfoProvider template code and refactor StorageInfoProvider based on it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h

Issue 10876041: Polish the SystemInfoProvider template code and refactor StorageInfoProvider based on it (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_linux.cc » ('j') | chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h

diff --git a/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h b/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h

index b0cb12f56292172f6aeb89836b05a23fc26eb641..c393c3cc33679f84287c4df712f155b2661d5579 100644

--- a/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h

+++ b/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h

@@ -9,8 +9,14 @@

namespace extensions {

-typedef SystemInfoProvider<api::experimental_system_info_cpu::CpuInfo>

- CpuInfoProvider;

+class CpuInfoProvider

+ : public SystemInfoProvider<api::experimental_system_info_cpu::CpuInfo> {

+ public:

+ virtual ~CpuInfoProvider() {}

Mihai Parparita -not on Chrome 2012/08/24 00:57:29 Body of this class declaration is indented too muc

+ // Return the single shared instance of CpuInfoProvider.

+ static CpuInfoProvider* Get();

+};

} // namespace extensions