[Sync] Rework Invalidator-related unit tests

sync/notifier/invalidation_util.h

Index: sync/notifier/invalidation_util.h
diff --git a/sync/notifier/invalidation_util.h b/sync/notifier/invalidation_util.h
index 2f3198bc42a63d84ac4220360914dc9544141048..6fcd93e918ddbc36a37c3a0269a6dc75f2150cd1 100644
--- a/sync/notifier/invalidation_util.h
+++ b/sync/notifier/invalidation_util.h
@@ -13,6 +13,10 @@
 
 #include "sync/internal_api/public/base/model_type.h"
 
+namespace base {
+class DictionaryValue;
+}  // namespace
+
 namespace invalidation {
 
 class Invalidation;
@@ -38,11 +42,18 @@ bool RealModelTypeToObjectId(ModelType model_type,
 bool ObjectIdToRealModelType(const invalidation::ObjectId& object_id,
                              ModelType* model_type);
 
-ObjectIdSet ModelTypeSetToObjectIdSet(const ModelTypeSet& models);
-ModelTypeSet ObjectIdSetToModelTypeSet(const ObjectIdSet& ids);
+// Caller owns the returned DictionaryValue.
+base::DictionaryValue* ObjectIdToValue(

[Nicolas Zea, 2012/08/29 23:41:05]

return scoped ptr?

[akalin, 2012/08/30 22:20:38]

Done.

+    const invalidation::ObjectId& object_id);
+
+bool ObjectIdFromValue(const base::DictionaryValue& value,
+                       invalidation::ObjectId* out);
 
 std::string ObjectIdToString(const invalidation::ObjectId& object_id);
 
+ObjectIdSet ModelTypeSetToObjectIdSet(const ModelTypeSet& models);
+ModelTypeSet ObjectIdSetToModelTypeSet(const ObjectIdSet& ids);
+
 std::string InvalidationToString(
     const invalidation::Invalidation& invalidation);