net: Add a new target 'net_with_v8'.

net/proxy/proxy_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_SERVICE_H_
 #define NET_PROXY_PROXY_SERVICE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 28 matching lines @@
 class ProxyScriptDecider;
 class ProxyScriptFetcher;
 
 // This class can be used to resolve the proxy server to use when loading a
 // HTTP(S) URL.  It uses the given ProxyResolver to handle the actual proxy
 // resolution.  See ProxyResolverV8 for example.
 class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver,
                                 public ProxyConfigService::Observer,
                                 NON_EXPORTED_BASE(public base::NonThreadSafe) {
  public:
+  static const size_t kDefaultNumPacThreads;
+
   // This interface defines the set of policies for when to poll the PAC
   // script for changes.
   //
   // The polling policy decides what the next poll delay should be in
   // milliseconds. It also decides how to wait for this delay -- either
   // by starting a timer to do the poll at exactly |next_delay_ms|
   // (MODE_USE_TIMER) or by waiting for the first network request issued after
   // |next_delay_ms| (MODE_START_AFTER_ACTIVITY).
   //
   // The timer method is more precise and guarantees that polling happens when
@@ skipping 132 matching lines @@
   // Clears the list of bad proxy servers that has been cached.
   void ClearBadProxiesCache() {
     proxy_retry_info_.clear();
   }
 
   // Forces refetching the proxy configuration, and applying it.
   // This re-does everything from fetching the system configuration,
   // to downloading and testing the PAC files.
   void ForceReloadProxyConfig();
 
-  // Creates a proxy service that polls |proxy_config_service| to notice when
-  // the proxy settings change. We take ownership of |proxy_config_service|.
-  //
-  // |num_pac_threads| specifies the maximum number of threads to use for
-  // executing PAC scripts. Threads are created lazily on demand.
-  // If |0| is specified, then a default number of threads will be selected.
-  //
-  // Having more threads avoids stalling proxy resolve requests when the
-  // PAC script takes a while to run. This is particularly a problem when PAC
-  // scripts do synchronous DNS resolutions, since that can take on the order
-  // of seconds.
-  //
-  // However, the disadvantages of using more than 1 thread are:
-  //   (a) can cause compatibility issues for scripts that rely on side effects
-  //       between runs (such scripts should not be common though).
-  //   (b) increases the memory used by proxy resolving, as each thread will
-  //       duplicate its own script context.
-
-  // |proxy_script_fetcher| specifies the dependency to use for downloading
-  // any PAC scripts. The resulting ProxyService will take ownership of it.
-  //
-  // |dhcp_proxy_script_fetcher| specifies the dependency to use for attempting
-  // to retrieve the most appropriate PAC script configured in DHCP. The
-  // resulting ProxyService will take ownership of it.
-  //
-  // |host_resolver| points to the host resolving dependency the PAC script
-  // should use for any DNS queries. It must remain valid throughout the
-  // lifetime of the ProxyService.
-  //
-  // ##########################################################################
-  // # See the warnings in net/proxy/proxy_resolver_v8.h describing the
-  // # multi-threading model. In order for this to be safe to use, *ALL* the
-  // # other V8's running in the process must use v8::Locker.
-  // ##########################################################################
-  static ProxyService* CreateUsingV8ProxyResolver(
-      ProxyConfigService* proxy_config_service,
-      size_t num_pac_threads,
-      ProxyScriptFetcher* proxy_script_fetcher,
-      DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher,
-      HostResolver* host_resolver,
-      NetLog* net_log,
-      NetworkDelegate* network_delegate);
-
   // Same as CreateUsingV8ProxyResolver, except it uses system libraries

[eroman, 2012/08/28 01:37:42]

Please update this. At the very least update the name, even better would be to
inline comments.

[tfarina, 2012/08/30 02:45:52]

Done.

   // for evaluating the PAC script if available, otherwise skips
   // proxy autoconfig.
   static ProxyService* CreateUsingSystemProxyResolver(
       ProxyConfigService* proxy_config_service,
       size_t num_pac_threads,
       NetLog* net_log);
 
   // Creates a ProxyService without support for proxy autoconfig.
   static ProxyService* CreateWithoutProxyResolver(
       ProxyConfigService* proxy_config_service,
@@ skipping 207 matching lines @@
 
   base::WaitableEvent event_;
   CompletionCallback callback_;
   ProxyInfo proxy_info_;
   int result_;
 };
 
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_SERVICE_H_