Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

Issue 10874068: When using action box on Mac, hide star when page is not bookmarked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Applied review comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_
6 #define CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_ 6 #define CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #import <Cocoa/Cocoa.h> 10 #import <Cocoa/Cocoa.h>
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 204
205 // Checks if the bookmark star should be enabled or not. 205 // Checks if the bookmark star should be enabled or not.
206 bool IsStarEnabled(); 206 bool IsStarEnabled();
207 207
208 // Update the Chrome To Mobile page action visibility and command state. 208 // Update the Chrome To Mobile page action visibility and command state.
209 void UpdateChromeToMobileEnabled(); 209 void UpdateChromeToMobileEnabled();
210 210
211 // Updates the zoom decoration in the omnibox with the current zoom level. 211 // Updates the zoom decoration in the omnibox with the current zoom level.
212 void UpdateZoomDecoration(); 212 void UpdateZoomDecoration();
213 213
214 // Ensures the star decoration is visible or hidden, as required.
215 void UpdateStarDecorationVisibility();
216
214 scoped_ptr<OmniboxViewMac> omnibox_view_; 217 scoped_ptr<OmniboxViewMac> omnibox_view_;
215 218
216 CommandUpdater* command_updater_; // Weak, owned by Browser. 219 CommandUpdater* command_updater_; // Weak, owned by Browser.
217 220
218 AutocompleteTextField* field_; // owned by tab controller 221 AutocompleteTextField* field_; // owned by tab controller
219 222
220 // When we get an OnAutocompleteAccept notification from the autocomplete 223 // When we get an OnAutocompleteAccept notification from the autocomplete
221 // edit, we save the input string so we can give it back to the browser on 224 // edit, we save the input string so we can give it back to the browser on
222 // the LocationBar interface via GetInputString(). 225 // the LocationBar interface via GetInputString().
223 string16 location_input_; 226 string16 location_input_;
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 // Used to schedule a task for the first run info bubble. 278 // Used to schedule a task for the first run info bubble.
276 base::WeakPtrFactory<LocationBarViewMac> weak_ptr_factory_; 279 base::WeakPtrFactory<LocationBarViewMac> weak_ptr_factory_;
277 280
278 // Used to change the visibility of the star decoration. 281 // Used to change the visibility of the star decoration.
279 BooleanPrefMember edit_bookmarks_enabled_; 282 BooleanPrefMember edit_bookmarks_enabled_;
280 283
281 DISALLOW_COPY_AND_ASSIGN(LocationBarViewMac); 284 DISALLOW_COPY_AND_ASSIGN(LocationBarViewMac);
282 }; 285 };
283 286
284 #endif // CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_ 287 #endif // CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698