[Chromoting] Hook up host talkgadget policy checks.

remoting/host/signaling_connector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/signaling_connector.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
+#include "net/url_request/url_fetcher.h"
 #include "remoting/host/chromoting_host_context.h"
+#include "remoting/host/connection_block_checker.h"
+#include "remoting/host/constants.h"
 #include "remoting/host/url_request_context.h"
 
 namespace remoting {
 
 namespace {
 
 // The delay between reconnect attempts will increase exponentially up
 // to the maximum specified here.
 const int kMaxReconnectDelaySeconds = 10 * 60;
 
 // Time when we we try to update OAuth token before its expiration.
 const int kTokenUpdateTimeBeforeExpirySeconds = 60;
 
 }  // namespace
 
 SignalingConnector::OAuthCredentials::OAuthCredentials(
     const std::string& login_value,
     const std::string& refresh_token_value,
     const OAuthClientInfo& client_info_value)
     : login(login_value),
       refresh_token(refresh_token_value),
       client_info(client_info_value) {
 }
 
 SignalingConnector::SignalingConnector(
     XmppSignalStrategy* signal_strategy,
+    ChromotingHostContext* context,
+    std::string talkgadget_prefix,
     const base::Closure& auth_failed_callback)
     : signal_strategy_(signal_strategy),
+      context_(context),
       auth_failed_callback_(auth_failed_callback),
       reconnect_attempts_(0),
       refreshing_oauth_token_(false) {
   DCHECK(!auth_failed_callback_.is_null());
   net::NetworkChangeNotifier::AddConnectionTypeObserver(this);
   net::NetworkChangeNotifier::AddIPAddressObserver(this);
   signal_strategy_->AddListener(this);
+  connection_block_checker_.reset(
+      new ConnectionBlockChecker(context_, talkgadget_prefix));
   ScheduleTryReconnect();
 }
 
 SignalingConnector::~SignalingConnector() {
   signal_strategy_->RemoveListener(this);
   net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
   net::NetworkChangeNotifier::RemoveIPAddressObserver(this);
 }
 
 void SignalingConnector::EnableOAuth(
-    scoped_ptr<OAuthCredentials> oauth_credentials,
-    net::URLRequestContextGetter* url_context) {
+    scoped_ptr<OAuthCredentials> oauth_credentials) {
   oauth_credentials_ = oauth_credentials.Pass();
   gaia_oauth_client_.reset(new GaiaOAuthClient(
-      OAuthProviderInfo::GetDefault(), url_context));
+      OAuthProviderInfo::GetDefault(), context_->url_request_context_getter()));
 }
 
 void SignalingConnector::OnSignalStrategyStateChange(
     SignalStrategy::State state) {
   DCHECK(CalledOnValidThread());
 
   if (state == SignalStrategy::CONNECTED) {
     LOG(INFO) << "Signaling connected.";
     reconnect_attempts_ = 0;
   } else if (state == SignalStrategy::DISCONNECTED) {
     LOG(INFO) << "Signaling disconnected.";
     reconnect_attempts_++;
 
     // If authentication failed then we have an invalid OAuth token,
     // inform the upper layer about it.
     if (signal_strategy_->GetError() == SignalStrategy::AUTHENTICATION_FAILED) {
       auth_failed_callback_.Run();
     } else {
       ScheduleTryReconnect();
     }
   }
 }
 
 bool SignalingConnector::OnSignalStrategyIncomingStanza(
     const buzz::XmlElement* stanza) {
   return false;
 }
 
-void SignalingConnector::OnIPAddressChanged() {
-  DCHECK(CalledOnValidThread());
-  LOG(INFO) << "IP address has changed.";
-  ResetAndTryReconnect();
-}
-
 void SignalingConnector::OnConnectionTypeChanged(
     net::NetworkChangeNotifier::ConnectionType type) {
   DCHECK(CalledOnValidThread());
   if (type != net::NetworkChangeNotifier::CONNECTION_NONE) {
     LOG(INFO) << "Network state changed to online.";
     ResetAndTryReconnect();
   }
 }
 
+void SignalingConnector::OnIPAddressChanged() {
+  DCHECK(CalledOnValidThread());
+  LOG(INFO) << "IP address has changed.";
+  ResetAndTryReconnect();
+}
+
 void SignalingConnector::OnRefreshTokenResponse(const std::string& user_email,
                                                 const std::string& access_token,
                                                 int expires_seconds) {
   DCHECK(CalledOnValidThread());
   DCHECK(oauth_credentials_.get());
   LOG(INFO) << "Received OAuth token.";
 
   if (user_email != oauth_credentials_->login) {
     LOG(ERROR) << "OAuth token and email address do not refer to "
         "the same account.";
@@ skipping 43 matching lines @@
 void SignalingConnector::ResetAndTryReconnect() {
   DCHECK(CalledOnValidThread());
   signal_strategy_->Disconnect();
   reconnect_attempts_ = 0;
   timer_.Stop();
   ScheduleTryReconnect();
 }
 
 void SignalingConnector::TryReconnect() {
   DCHECK(CalledOnValidThread());
+  DCHECK(connection_block_checker_.get());
+
+  ConnectionBlockChecker::Status status;
+  status = connection_block_checker_->GetStatus();
+  if (status == ConnectionBlockChecker::UNKNOWN) {
+    ScheduleTryReconnect();
+    return;
+  } else if (status == ConnectionBlockChecker::DENY) {
+    return;

[Sergey Ulanov, 2012/08/28 00:33:42]

This will keep the host running even though we know that we will not be able to
connect. It would be better if we could shutdown the host if we know that it's
being blocked. Problem is that we cannot distinguish between it being blocked
and general network failure :(
So it doesn't look right to distinguish between DENY and UNKNOWN as they are not
reliable anyway. Probably it's better call ScheduleTryReconnect() either way -
that will also handle the case when access gets reenabled by the network
administrator.

The case that I'm worried about is that if user starts the host and everything
will look like the host is started, but it won't be possible to connect anyway.
Maybe we should add a check in the webapp (or the plugin) so that it would
verify that we are not blocked before enabling the host? What do you think? It
doesn't have to be part of this CL.

[garykac, 2012/08/29 00:07:15]

Done.
Yes, it would certainly be nice if the webapp could display this. It doesn't
have direct access to the policy values. But we could do it in the plugin or
expose the talkgadget url to the webapp.

+  }
+
   if (signal_strategy_->GetState() == SignalStrategy::DISCONNECTED) {
     bool need_new_auth_token = oauth_credentials_.get() &&
         (auth_token_expiry_time_.is_null() ||
          base::Time::Now() >= auth_token_expiry_time_);
     if (need_new_auth_token) {
       RefreshOAuthToken();
     } else {
       LOG(INFO) << "Attempting to connect signaling.";
       signal_strategy_->Connect();
     }
   }
 }
 
 void SignalingConnector::RefreshOAuthToken() {
   DCHECK(CalledOnValidThread());
   LOG(INFO) << "Refreshing OAuth token.";
   DCHECK(!refreshing_oauth_token_);
 
   refreshing_oauth_token_ = true;
   gaia_oauth_client_->RefreshToken(
       oauth_credentials_->client_info,
       oauth_credentials_->refresh_token, this);
 }
 
 }  // namespace remoting