[Chromoting] Hook up host talkgadget policy checks.

remoting/host/signaling_connector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/signaling_connector.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
+#include "net/url_request/url_fetcher.h"
 #include "remoting/host/chromoting_host_context.h"
+#include "remoting/host/constants.h"
+#include "remoting/host/dns_blackhole_checker.h"
 #include "remoting/host/url_request_context.h"
 
 namespace remoting {
 
 namespace {
 
 // The delay between reconnect attempts will increase exponentially up
 // to the maximum specified here.
 const int kMaxReconnectDelaySeconds = 10 * 60;
 
 // Time when we we try to update OAuth token before its expiration.
 const int kTokenUpdateTimeBeforeExpirySeconds = 60;
 
 }  // namespace
 
 SignalingConnector::OAuthCredentials::OAuthCredentials(
     const std::string& login_value,
     const std::string& refresh_token_value,
     const OAuthClientInfo& client_info_value)
     : login(login_value),
       refresh_token(refresh_token_value),
       client_info(client_info_value) {
 }
 
 SignalingConnector::SignalingConnector(
     XmppSignalStrategy* signal_strategy,
+    ChromotingHostContext* context,
+    DnsBlackholeChecker* dns_blackhole_checker,
     const base::Closure& auth_failed_callback)
     : signal_strategy_(signal_strategy),
+      context_(context),
       auth_failed_callback_(auth_failed_callback),
+      dns_blackhole_checker_(dns_blackhole_checker),
       reconnect_attempts_(0),
       refreshing_oauth_token_(false) {
   DCHECK(!auth_failed_callback_.is_null());
   net::NetworkChangeNotifier::AddConnectionTypeObserver(this);
   net::NetworkChangeNotifier::AddIPAddressObserver(this);
   signal_strategy_->AddListener(this);
   ScheduleTryReconnect();
 }
 
 SignalingConnector::~SignalingConnector() {
   signal_strategy_->RemoveListener(this);
   net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
   net::NetworkChangeNotifier::RemoveIPAddressObserver(this);
 }
 
 void SignalingConnector::EnableOAuth(
-    scoped_ptr<OAuthCredentials> oauth_credentials,
-    net::URLRequestContextGetter* url_context) {
+    scoped_ptr<OAuthCredentials> oauth_credentials) {
   oauth_credentials_ = oauth_credentials.Pass();
   gaia_oauth_client_.reset(new GaiaOAuthClient(
-      OAuthProviderInfo::GetDefault(), url_context));
+      OAuthProviderInfo::GetDefault(), context_->url_request_context_getter()));
 }
 
 void SignalingConnector::OnSignalStrategyStateChange(
     SignalStrategy::State state) {
   DCHECK(CalledOnValidThread());
 
   if (state == SignalStrategy::CONNECTED) {
     LOG(INFO) << "Signaling connected.";
     reconnect_attempts_ = 0;
   } else if (state == SignalStrategy::DISCONNECTED) {
     LOG(INFO) << "Signaling disconnected.";
     reconnect_attempts_++;
 
     // If authentication failed then we have an invalid OAuth token,
     // inform the upper layer about it.
     if (signal_strategy_->GetError() == SignalStrategy::AUTHENTICATION_FAILED) {
       auth_failed_callback_.Run();
     } else {
       ScheduleTryReconnect();
     }
   }
 }
 
 bool SignalingConnector::OnSignalStrategyIncomingStanza(
     const buzz::XmlElement* stanza) {
   return false;
 }
 
-void SignalingConnector::OnIPAddressChanged() {
-  DCHECK(CalledOnValidThread());
-  LOG(INFO) << "IP address has changed.";
-  ResetAndTryReconnect();
-}
-
 void SignalingConnector::OnConnectionTypeChanged(
     net::NetworkChangeNotifier::ConnectionType type) {
   DCHECK(CalledOnValidThread());
   if (type != net::NetworkChangeNotifier::CONNECTION_NONE) {
     LOG(INFO) << "Network state changed to online.";
     ResetAndTryReconnect();
   }
 }
 
+void SignalingConnector::OnIPAddressChanged() {
+  DCHECK(CalledOnValidThread());
+  LOG(INFO) << "IP address has changed.";
+  ResetAndTryReconnect();
+}
+
 void SignalingConnector::OnRefreshTokenResponse(const std::string& user_email,
                                                 const std::string& access_token,
                                                 int expires_seconds) {
   DCHECK(CalledOnValidThread());
   DCHECK(oauth_credentials_.get());
   LOG(INFO) << "Received OAuth token.";
 
   if (user_email != oauth_credentials_->login) {
     LOG(ERROR) << "OAuth token and email address do not refer to "
         "the same account.";
@@ skipping 27 matching lines @@
              << response_code;
   refreshing_oauth_token_ = false;
   reconnect_attempts_++;
   ScheduleTryReconnect();
 }
 
 void SignalingConnector::ScheduleTryReconnect() {
   DCHECK(CalledOnValidThread());
   if (timer_.IsRunning() || net::NetworkChangeNotifier::IsOffline())
     return;
-  int delay_s = std::min(1 << (reconnect_attempts_ * 2),

[Sergey Ulanov, 2012/08/30 18:05:01]

Why remove *2 here. Do we still have the problem with the first check always
failing?

[garykac, 2012/08/31 18:28:23]

Yes. I haven't been able to find any reason why this happens though. 

[Sergey Ulanov, 2012/08/31 23:40:16]

I actually see the same issue fetching OAuth token - the first attempt always
fails. We need to figure out why, but it's not related to this CL, so please
keep *2 here.

+  int delay_s = std::min(1 << reconnect_attempts_,
                          kMaxReconnectDelaySeconds);
   timer_.Start(FROM_HERE, base::TimeDelta::FromSeconds(delay_s),
                this, &SignalingConnector::TryReconnect);
 }
 
 void SignalingConnector::ResetAndTryReconnect() {
   DCHECK(CalledOnValidThread());
   signal_strategy_->Disconnect();
   reconnect_attempts_ = 0;
   timer_.Stop();
   ScheduleTryReconnect();
 }
 
 void SignalingConnector::TryReconnect() {
   DCHECK(CalledOnValidThread());
+  DCHECK(dns_blackhole_checker_);

[Sergey Ulanov, 2012/08/30 18:05:01]

maybe put this DCHECK in constructor?

[garykac, 2012/08/31 18:28:23]

Done.

+
+  // This will check if this machine is allowed to access the chromoting
+  // host talkgadget.
+  dns_blackhole_checker_->CheckForDnsBlackhole(
+      base::Bind(&SignalingConnector::OnDnsBlackholeCheckerDone,
+                 base::Unretained(this)));
+}
+
+void SignalingConnector::OnDnsBlackholeCheckerDone(bool allow) {
+  DCHECK(CalledOnValidThread());
+
+  // Unable to access the host talkgadget. Don't allow the connection, but
+  // schedule a reconnect in case this is a transient problem rather than
+  // an outright block.
+  if (!allow) {
+    reconnect_attempts_++;
+    LOG(INFO) << "Scheduling reconnect. Attempt " << reconnect_attempts_;
+    ScheduleTryReconnect();
+    return;
+  }
+
   if (signal_strategy_->GetState() == SignalStrategy::DISCONNECTED) {
     bool need_new_auth_token = oauth_credentials_.get() &&
         (auth_token_expiry_time_.is_null() ||
          base::Time::Now() >= auth_token_expiry_time_);
     if (need_new_auth_token) {
       RefreshOAuthToken();
     } else {
       LOG(INFO) << "Attempting to connect signaling.";
       signal_strategy_->Connect();
     }
   }
 }
 
 void SignalingConnector::RefreshOAuthToken() {
   DCHECK(CalledOnValidThread());
   LOG(INFO) << "Refreshing OAuth token.";
   DCHECK(!refreshing_oauth_token_);
 
   refreshing_oauth_token_ = true;
   gaia_oauth_client_->RefreshToken(
       oauth_credentials_->client_info,
       oauth_credentials_->refresh_token, this);
 }
 
 }  // namespace remoting