chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js - Issue 10873038: Replacing WebUIBindings use of CPPBoundClass with v8::Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js

Issue 10873038: Replacing WebUIBindings use of CPPBoundClass with v8::Extension. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Using typeof == "function" Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/api/fontSettings/js/cr.js ('k') | chrome/test/data/webui/certificate_viewer_dialog_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js

diff --git a/chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js b/chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js

index 52e25240b73564a261748cd5f6d8d6aca92f6a6b..28e27224edec807c6ff56fa43384fc4823c14490 100644

--- a/chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js

+++ b/chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr.js

@@ -32,13 +32,15 @@ const cr = (function() {

* Whether this uses GTK or not.

* @type {boolean}

- const isGTK = /GTK/.test(chrome.toolkit);

+ const isGTK = typeof chrome.getVariableValue == 'function' &&

+ /GTK/.test(chrome.getVariableValue('toolkit'));

/**

* Whether this uses the views toolkit or not.

* @type {boolean}

- const isViews = /views/.test(chrome.toolkit);

+ const isViews = typeof chrome.getVariableValue == 'function' &&

+ /views/.test(chrome.getVariableValue('toolkit'));

/**

* Sets the os and toolkit attributes in the <html> element so that platform