Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 10873026: Rename GDataSystemService to DriveSystemService (Closed)

Created:
8 years, 4 months ago by kochi
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, rdsmith+dwatch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, kinuko
Visibility:
Public.

Description

Rename GDataSystemService to DriveSystemService In this CL, the following changes are included: * Rename GDataSystemService class to DriveSystemService * gdata_system_service.{h,cc} have been renamed to drive_system_service.{h,cc} This applies on top of https://chromiumcodereview.appspot.com/10874028/ and https://chromiumcodereview.appspot.com/10877006/ BUG=137151 TEST=pass all existing tests. TBR=satorux@chromium.org, ben@chromium.org, estade@chromium.org, ahendrickson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153460

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase. #

Patch Set 3 : rebase #

Patch Set 4 : Fix merge issue, remove one include header which is no longer necessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -530 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 15 chunks +29 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_proxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_file_system_proxy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/gdata/drive_system_service.h View 1 2 7 chunks +22 lines, -22 lines 0 comments Download
A + chrome/browser/chromeos/gdata/drive_system_service.cc View 1 2 9 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_task_executor.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/gdata/file_write_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/file_write_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_download_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_download_observer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_protocol_handler.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_sync_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_system_service.h View 1 2 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_system_service.cc View 1 2 1 chunk +0 lines, -228 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_util.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kochi
Hi Satoru, Daniel, Could you review this? Thanks, As GDataContactsService is now dependent on DriveSystemService, ...
8 years, 4 months ago (2012-08-23 09:42:47 UTC) #1
kochi
Kazuhiro, could you take a look at this CL for Satoru's absence? Thanks, On 2012/08/23 ...
8 years, 4 months ago (2012-08-23 09:56:28 UTC) #2
kinaba
LGTM with a nit for renaming, leaving GDataContactsService's dependency stuff to other reviewers. http://codereview.chromium.org/10873026/diff/1/chrome/browser/chromeos/gdata/drive_file_system_proxy.cc File ...
8 years, 4 months ago (2012-08-23 10:57:39 UTC) #3
Daniel Erat
I agree that GDataContactsService shouldn't be owned by a class named DriveSystemService. :-) I think ...
8 years, 4 months ago (2012-08-23 16:27:18 UTC) #4
Daniel Erat
Seems like it works. I'm okay with GDataContactsService temporarily being owned by a class named ...
8 years, 4 months ago (2012-08-23 17:57:01 UTC) #5
kochi
Merged https://chromiumcodereview.appspot.com/10882017/, added TBR=. Satoru, could you check c/b/extensions, c/b/chromeos Ben, could you check .gypi ...
8 years, 3 months ago (2012-08-27 10:48:37 UTC) #6
Randy Smith (Not in Mondays)
c/b/download LGTM.
8 years, 3 months ago (2012-08-27 13:54:49 UTC) #7
Ben Goodger (Google)
8 years, 3 months ago (2012-08-27 15:51:07 UTC) #8
gyp lgtm

Powered by Google App Engine
This is Rietveld 408576698