Issue 10872092: Update build-deb.sh to automatically detect version number.

Issue 10872092: Update build-deb.sh to automatically detect version number. (Closed)

Created:
8 years, 3 months ago by Sergey Ulanov

Modified:
8 years, 3 months ago

Reviewers:
Lambros

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update build-deb.sh to automatically detect version number. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153539

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 3

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	remoting/host/installer/linux/build-deb.sh	View	1	1 chunk	+14 lines, -1 line	3 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Jamie

http://codereview.chromium.org/10872092/diff/1/remoting/host/installer/linux/build-deb.sh File remoting/host/installer/linux/build-deb.sh (right): http://codereview.chromium.org/10872092/diff/1/remoting/host/installer/linux/build-deb.sh#newcode15 remoting/host/installer/linux/build-deb.sh:15: echo "Building version $version_full" Drive-by: This line should probably ...

8 years, 3 months ago (2012-08-27 20:21:09 UTC) #2

Sergey Ulanov

Also added check to make sure we always get version in the correct format. http://codereview.chromium.org/10872092/diff/1/remoting/host/installer/linux/build-deb.sh ...

8 years, 3 months ago (2012-08-27 20:55:40 UTC) #4

Jamie

http://codereview.chromium.org/10872092/diff/3002/remoting/host/installer/linux/build-deb.sh File remoting/host/installer/linux/build-deb.sh (right): http://codereview.chromium.org/10872092/diff/3002/remoting/host/installer/linux/build-deb.sh#newcode18 remoting/host/installer/linux/build-deb.sh:18: "^[[:digit:]]+.[[:digit:]]+.[[:digit:]]+.[[:digit:]]+$" > /dev/null); then Strictly speaking, you should escape ...

8 years, 3 months ago (2012-08-27 21:03:31 UTC) #5

Lambros

http://codereview.chromium.org/10872092/diff/3002/remoting/host/installer/linux/build-deb.sh File remoting/host/installer/linux/build-deb.sh (right): http://codereview.chromium.org/10872092/diff/3002/remoting/host/installer/linux/build-deb.sh#newcode17 remoting/host/installer/linux/build-deb.sh:17: if !(echo $version_full | grep -E \ Optional: maybe ...

8 years, 3 months ago (2012-08-27 21:39:32 UTC) #6

Sergey Ulanov

8 years, 3 months ago (2012-08-28 00:41:07 UTC) #7

http://codereview.chromium.org/10872092/diff/3002/remoting/host/installer/lin...
File remoting/host/installer/linux/build-deb.sh (right):

http://codereview.chromium.org/10872092/diff/3002/remoting/host/installer/lin...
remoting/host/installer/linux/build-deb.sh:17: if !(echo $version_full | grep -E
\
On 2012/08/27 21:39:33, Lambros wrote:
> Optional: maybe move this check into the first if.. block, in case we ever
want
> to build with a tweaked version string?

It's intentionally outside of the previous if to make sure version is correct
even when specified externally. We can always change this regex if we ever need
to support different version string format.

Expand Messages | Collapse Messages