Issue 10872035: Add a simple dominator based redundancy elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10872035: Add a simple dominator based redundancy elimination. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add a simple dominator based redundancy elimination. It enables elimination of redundant expressions across basic blocks. Currently used for smi checks and class checks, but will be extended to other expressions in a separate CL. Committed: https://code.google.com/p/dart/source/detail?r=11227

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -35 lines)			Patch
M	runtime/vm/compiler.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+37 lines, -21 lines	2 comments	Download
M	runtime/vm/hash_map.h	View		3 chunks	+17 lines, -2 lines	0 comments	Download
M	runtime/vm/hash_map_test.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

LGTM! https://chromiumcodereview.appspot.com/10872035/diff/6001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10872035/diff/6001/runtime/vm/flow_graph_optimizer.cc#newcode990 runtime/vm/flow_graph_optimizer.cc:990: if (i < num_children - 1) { There's ...

8 years, 4 months ago (2012-08-23 13:12:39 UTC) #2

Florian Schneider

8 years, 4 months ago (2012-08-23 13:17:50 UTC) #3

https://chromiumcodereview.appspot.com/10872035/diff/6001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10872035/diff/6001/runtime/vm/flow_gra...
runtime/vm/flow_graph_optimizer.cc:990: if (i  < num_children - 1) {
On 2012/08/23 13:12:39, kmillikin wrote:
> There's an extra space here for some reason.

Done.

Expand Messages | Collapse Messages