chrome/chrome_browser.gypi - Issue 10872034: Changing PluginPrefs to use PluginFinder's async interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 10872034: Changing PluginPrefs to use PluginFinder's async interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@test_async

Patch Set: Remove exclusion of plugin_installer and plugin_finder from build when enable_plugin_installation i… Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 4f8650f4675510de717196b70e4cd6a4db54f970..957be770a2c9f08a74a080c90ab8e15866fdeb6a 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -5438,10 +5438,7 @@

}],

['enable_plugin_installation==0', {

'sources!': [

- 'browser/plugin_finder.cc',

- 'browser/plugin_finder.h',

- 'browser/plugin_installer.cc',

- 'browser/plugin_installer.h',

+ # TODO(ibraaaa): Return plugin_installer.{h/cc}.

'browser/plugin_installer_observer.cc',

'browser/plugin_installer_observer.h',

« chrome/browser/ui/webui/plugins_ui.cc ('K') | « chrome/browser/ui/webui/plugins_ui.cc ('k') | no next file » | no next file with comments »