Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/component_updater/pepper_flash_component_installer.cc

Issue 10872034: Changing PluginPrefs to use PluginFinder's async interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@test_async
Patch Set: Fixed bauerb's review comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/pepper_flash_component_installer.cc
diff --git a/chrome/browser/component_updater/pepper_flash_component_installer.cc b/chrome/browser/component_updater/pepper_flash_component_installer.cc
index a5f6545b628e32dd640eccd5a830e0992dccdcf0..91511707e529180c145bc30d81396b76d92be309 100644
--- a/chrome/browser/component_updater/pepper_flash_component_installer.cc
+++ b/chrome/browser/component_updater/pepper_flash_component_installer.cc
@@ -165,6 +165,9 @@ bool MakePepperFlashPluginInfo(const FilePath& flash_path,
return true;
}
+void CanEnablePluginCallbackDoNothing(bool dummy) {
Bernhard Bauer 2012/08/29 16:53:21 We could add a comment that we're fine with ignori
ibraaaa 2012/08/29 17:37:53 Done.
+}
+
// If it is a |fresh_install| we enable or disable it by default in some
// configurations. See IsPepperFlashEnabledByDefault() for more information.
void RegisterPepperFlashWithChrome(const FilePath& path,
@@ -176,8 +179,10 @@ void RegisterPepperFlashWithChrome(const FilePath& path,
return;
bool enable_by_default = IsPepperFlashEnabledByDefault();
if (fresh_install)
- PluginPrefs::EnablePluginGlobally(enable_by_default, plugin_info.path,
- base::Bind(&base::DoNothing));
+ PluginPrefs::EnablePluginGlobally(
+ enable_by_default,
+ plugin_info.path,
+ base::Bind(&CanEnablePluginCallbackDoNothing));
bool add_to_front = enable_by_default;
PluginService::GetInstance()->RegisterInternalPlugin(

Powered by Google App Engine
This is Rietveld 408576698