Changing PluginPrefs to use PluginFinder's async interface.

chrome/browser/plugin_prefs_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugin_prefs.h"
 
 #include "base/at_exit.h"
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/plugins/npapi/mock_plugin_list.cc"
 #include "webkit/plugins/webplugininfo.h"
 
 using content::BrowserThread;
 using content::PluginService;
 
+namespace {
+
+void CanEnablePluginCallback(bool dummy) {

[Bernhard Bauer, 2012/08/31 12:54:11]

Nit: Aaaand now please don't call the parameter |dummy| anymore :-)

[ibraaaa, 2012/09/03 08:55:22]

Done.

+  ASSERT_TRUE(dummy);
+  MessageLoop::current()->QuitWhenIdle();
+}
+
+}  // namespace
+
 class PluginPrefsTest : public ::testing::Test {
  public:
   virtual void SetUp() OVERRIDE {
     plugin_prefs_ = new PluginPrefs();
   }
 
   void SetPolicyEnforcedPluginPatterns(
       const std::set<string16>& disabled,
       const std::set<string16>& disabled_exceptions,
       const std::set<string16>& enabled) {
@@ skipping 123 matching lines @@
       profile_manager.CreateTestingProfile("Profile 1");
   PluginPrefs* plugin_prefs = PluginPrefs::GetForTestingProfile(profile_1);
   ASSERT_TRUE(plugin_prefs);
   plugin_prefs->SetPluginListForTesting(&plugin_list);
 
   webkit::WebPluginInfo plugin(ASCIIToUTF16("Foo"),
                                FilePath(FILE_PATH_LITERAL("/path/too/foo")),
                                ASCIIToUTF16("1.0.0"),
                                ASCIIToUTF16("Foo plug-in"));
   plugin_list.AddPluginToLoad(plugin);
-  PluginPrefs::EnablePluginGlobally(false, plugin.path,
-                                    MessageLoop::QuitClosure());
+  PluginPrefs::EnablePluginGlobally(
+      false, plugin.path,
+      base::Bind(&CanEnablePluginCallback));
 
   message_loop.Run();
 
   EXPECT_FALSE(plugin_prefs->IsPluginEnabled(plugin));
 
   TestingProfile* profile_2 =
       profile_manager.CreateTestingProfile("Profile 2");
   PluginPrefs* plugin_prefs_2 = PluginPrefs::GetForTestingProfile(profile_2);
   ASSERT_TRUE(plugin_prefs);
   plugin_prefs_2->SetPluginListForTesting(&plugin_list);
   EXPECT_FALSE(plugin_prefs_2->IsPluginEnabled(plugin));
 
   profile_manager.DeleteTestingProfile("Profile 1");
   profile_manager.DeleteTestingProfile("Profile 2");
 }