Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: SConstruct

Issue 10871078: Enable vdiff test on validator bots (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Fixing a few nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index 70019810b36d9087dedddfa2a3834ac02b689cf1..fff7d41e1a46b1434ee72c3a74e5b20bd4b5fcb1 100755
--- a/SConstruct
+++ b/SConstruct
@@ -336,6 +336,9 @@ def SetUpArgumentBits(env):
#
BitFromArgument(env, 'ncval_testing', default=False,
desc='EXPERIMENTAL: Compile validator code for testing within enuminsts')
+ # Diff test comparing old validator with new R-DFA validator
+ BitFromArgument(env, 'validator_diff_tests', default=False,
bradn 2012/08/28 21:14:10 So I think you should be able to drop this. This i
Brad Chen 2012/08/28 22:09:42 Done.
+ desc='Compare validator implementations')
# PNaCl sanity checks
if ((env.Bit('pnacl_generate_pexe') or env.Bit('use_sandboxed_translator'))
@@ -626,6 +629,8 @@ MAJOR_TEST_SUITES = set([
'tsan_bot_tests',
# Special testing environment for testing comparing x86 validators.
'ncval_testing',
+ # Environment for validator difference testing
+ 'validator_diff_tests',
])
# These are the test suites we know exist, but aren't run on a regular basis.
@@ -1535,7 +1540,7 @@ TEST_EXTRA_ARGS = ['stdin', 'log_file',
'osenv', 'arch', 'subarch', 'exit_status', 'track_cmdtime',
'num_runs', 'process_output_single',
'process_output_combined', 'using_nacl_signal_handler',
- 'declares_exit_status']
+ 'declares_exit_status', 'time_warning', 'time_error']
TEST_TIME_THRESHOLD = {
'small': 2,
« no previous file with comments | « no previous file | buildbot/buildbot_standard.py » ('j') | src/trusted/validator/x86/testing/enuminsts/build.scons » ('J')

Powered by Google App Engine
This is Rietveld 408576698