Make NaCl IPC-based PPAPI proxy build on ARM.

build/common_untrusted.gypi

Index: build/common_untrusted.gypi
===================================================================
--- build/common_untrusted.gypi	(revision 0)
+++ build/common_untrusted.gypi	(revision 0)
@@ -0,0 +1,28 @@
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# This GYP file should be included in every NaCl build of Chrome code.

[dmichael (off chromium), 2012/08/23 17:49:45]

NaCl is maybe a little ambiguous here, and "target" might be a better word than
"build".

Maybe more like...  "This GYP file should be included for every target in
Chromium that is built using the NaCl toolchain."? Or is that too wordy :)

[bbudge, 2012/08/23 20:32:29]

Done. Thanks for the excellent comment.

+{
+  'includes': [
+    '../native_client/build/untrusted.gypi',
+  ],
+  'target_defaults': {
+    'variables': {
+      'conditions': [
+        ['target_arch=="arm"', {
+          'defines': [
+            # Disable ValGrind. The assembly it generates causes the build
+            # to fail.
+            'NVALGRIND',
+          ],
+          'compile_flags': [
+            # Disable C++ 11 extensions. Chrome's OVERRIDE macro will generate

[brettw, 2012/08/23 03:55:16]

I'm surprised about this. Are there a bunch of OVERRIDES that are broken? I
would not expect there to be non-real errors with OVERRIDE. If there are a few
cases because of our ifdefs, can we fix them instead of doing this?

[bbudge, 2012/08/23 12:29:30]

There are a bunch (> 1100) of them, coming from base and gpu/command_buffer in
the builds I've seen. I will talk to the PNaCl guys, as this should be their
compiler.

 In file included from at_exit.cc:5:
 In file included from ../base/at_exit.h:12:
 In file included from ../base/callback.h:14:
 In file included from ../base/callback_internal.h:14:
 In file included from ../base/memory/ref_counted.h:12:
 ../base/threading/thread_collision_warner.h:141:23: warning:
'override' keyword is a C++11 extension [-Wc++11-extensions]
   virtual void warn() OVERRIDE;
                       ^
 ../base/compiler_specific.h:135:18: note: expanded
from macro 'OVERRIDE'
 #define OVERRIDE override

[dmichael (off chromium), 2012/08/23 17:46:32]

Is this relevant?
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/EUXSi0QvXnc/dis...
It sounds like maybe you need tu set the "clang" gyp variable to 1 for your arm
targets.

[bbudge, 2012/08/23 20:32:29]

Done. Yep, that works.

+            # warnings that cause the build to fail.
+            '-Wno-c++11-extensions',
+          ],
+        }],
+      ],
+    },
+  },
+}