Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 10870093: Rename ScopedStartupInfoEx to StartupInformation and cleanup accesors (Closed)

Created:
8 years, 4 months ago by jschuh
Modified:
8 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org, rvargas (doing something else)
Visibility:
Public.

Description

* Rename ScopedStartupInfoEx to StartupInformation. * Add const accessor for startup_info_ member. * Add has_extended_startup_info check. * Make startup_info_ member explicitly unicode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153543

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -247 lines) Patch
M base/base.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D base/win/scoped_startup_info_ex.h View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D base/win/scoped_startup_info_ex.cc View 1 2 3 1 chunk +0 lines, -109 lines 0 comments Download
D base/win/scoped_startup_info_ex_unittest.cc View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
A + base/win/startup_information.h View 1 2 3 chunks +15 lines, -8 lines 0 comments Download
A + base/win/startup_information.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + base/win/startup_information_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jschuh
This is just a class and file rename. Ricardo legitimately complained that the classname was ...
8 years, 4 months ago (2012-08-25 23:59:28 UTC) #1
jschuh
On 2012/08/25 23:59:28, Justin Schuh wrote: > This is just a class and file rename. ...
8 years, 4 months ago (2012-08-26 01:12:25 UTC) #2
brettw
lgtm
8 years, 3 months ago (2012-08-27 17:23:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/10870093/2003
8 years, 3 months ago (2012-08-27 19:30:40 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 19:30:42 UTC) #5
Failed to apply patch for base/win/startup_information.cc:
While running patch -p0 --forward --force;
patching file base/win/startup_information.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 36.
Hunk #3 FAILED at 64.
Hunk #4 FAILED at 94.
4 out of 4 hunks FAILED -- saving rejects to file
base/win/startup_information.cc.rej

Powered by Google App Engine
This is Rietveld 408576698