[WebIntents, Views] First version of "Waiting" dialog for views.

chrome/browser/ui/intents/web_intent_picker_controller.cc

Index: chrome/browser/ui/intents/web_intent_picker_controller.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc
index 64fdf2a93a62902570a86309b4ade165b9941808..394c37820619972c13a9a20fb26a4ab09b6ee022 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc
@@ -419,7 +419,7 @@ void WebIntentPickerController::OnChooseAnotherService() {
 }
 
 void WebIntentPickerController::OnClosing() {
-  picker_shown_ = false;
+  SetDialogState(kPickerHidden);
   picker_ = NULL;
 }
 
@@ -888,7 +888,6 @@ void WebIntentPickerController::SetDialogState(WebIntentPickerState state) {
   switch (state) {
     case kPickerSetup:
       DCHECK(dialog_state_ == kPickerHidden);

[tfarina, 2012/08/26 12:45:54]

nit:
DCHECK_EQ(expected, actual);

so
DCHECK_EQ(kPickerHidden, dialog_state_);

?

[groby-ooo-7-16, 2012/08/28 00:08:17]

Done.

-

[tfarina, 2012/08/26 12:45:54]

is necessary to remove this empty line? I think it might help in readability.

[groby-ooo-7-16, 2012/08/28 00:08:17]

It doesn't add much clarity, either.
On 2012/08/26 12:45:54, tfarina wrote:

       // Post timer CWS pending
       MessageLoop::current()->PostDelayedTask(FROM_HERE,
           base::Bind(&WebIntentPickerController::OnPickerEvent,