Change FaviconData to be able to return data for multiple bitmaps for same icon URL

chrome/browser/jumplist_win.h

Index: chrome/browser/jumplist_win.h
diff --git a/chrome/browser/jumplist_win.h b/chrome/browser/jumplist_win.h
index 5cd8fdc277399cf1b3a19ffe6901f9203cd84439..e3fc06558e204f2233a8325ccf49fe96336e5a98 100644
--- a/chrome/browser/jumplist_win.h
+++ b/chrome/browser/jumplist_win.h
@@ -51,7 +51,7 @@ class ShellLinkItem : public base::RefCountedThreadSafe<ShellLinkItem> {
   const std::wstring& title() const { return title_; }
   const std::wstring& icon() const { return icon_; }
   int index() const { return index_; }
-  scoped_refptr<base::RefCountedMemory> data() const { return data_; }
+  SkBitmap data() const { return data_; }

[sky, 2012/08/27 14:52:01]

const SkBitmap&

 
   void SetArguments(const std::wstring& arguments) {
     arguments_ = arguments;
@@ -67,7 +67,7 @@ class ShellLinkItem : public base::RefCountedThreadSafe<ShellLinkItem> {
     favicon_ = favicon;
   }
 
-  void SetIconData(scoped_refptr<base::RefCountedMemory> data) {
+  void SetIconData(const SkBitmap& data) {
     data_ = data;
   }
 
@@ -79,7 +79,7 @@ class ShellLinkItem : public base::RefCountedThreadSafe<ShellLinkItem> {
   std::wstring arguments_;
   std::wstring title_;
   std::wstring icon_;
-  scoped_refptr<base::RefCountedMemory> data_;
+  SkBitmap data_;
   int index_;
   bool favicon_;
 
@@ -176,8 +176,9 @@ class JumpList : public TabRestoreServiceObserver,
   // a ShellLinkItem object.
   // When finishing loading all favicons, this function posts a task that
   // decompresses collected favicons and updates a JumpList.
-  void OnFaviconDataAvailable(HistoryService::Handle handle,
-                              history::FaviconData favicon);
+  void OnFaviconDataAvailable(
+      HistoryService::Handle handle,
+      const history::FaviconImageResult& image_result);
 
   // Callback for TopSites that notifies when the "Most
   // Visited" list is available. This function updates the ShellLinkItemList
@@ -190,9 +191,9 @@ class JumpList : public TabRestoreServiceObserver,
   // has been fetched.
   void RunUpdate();
 
-  // Helper method for RunUpdate to decode the data about the asynchrounously
+  // Helper method for RunUpdate to create icon files for the asynchrounously
   // loaded icons.
-  void DecodeIconData(const ShellLinkItemList& item_list);
+  void CreateIconFiles(const ShellLinkItemList& item_list);
 
  private:
   friend class base::RefCountedThreadSafe<JumpList>;