Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3314)

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.cc

Issue 10870022: Change FaviconData to be able to return data for multiple bitmaps for same icon URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_icon_source.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_icon_source.cc b/chrome/browser/ui/webui/extensions/extension_icon_source.cc
index e0440fd79acb76a243b991a44f83bb73a5423a4a..27a51652cfaa71bf6ed1e6445e2bc2524eac6c38 100644
--- a/chrome/browser/ui/webui/extensions/extension_icon_source.cc
+++ b/chrome/browser/ui/webui/extensions/extension_icon_source.cc
@@ -223,25 +223,28 @@ void ExtensionIconSource::LoadFaviconImage(int request_id) {
void ExtensionIconSource::OnFaviconDataAvailable(
FaviconService::Handle request_handle,
- history::FaviconData favicon) {
+ history::FaviconData favicon_data,
+ std::vector<GURL> icon_urls_in_db) {
int request_id = cancelable_consumer_.GetClientData(
profile_->GetFaviconService(Profile::EXPLICIT_ACCESS), request_handle);
ExtensionIconRequest* request = GetData(request_id);
// Fallback to the default icon if there wasn't a favicon.
- if (!favicon.is_valid()) {
+ if (!favicon_data.has_valid_bitmaps()) {
LoadDefaultImage(request_id);
return;
}
+ scoped_refptr<base::RefCountedMemory> bitmap_data =
+ favicon_data.first_bitmap();
if (!request->grayscale) {
// If we don't need a grayscale image, then we can bypass FinalizeImage
// to avoid unnecessary conversions.
ClearData(request_id);
- SendResponse(request_id, favicon.image_data);
+ SendResponse(request_id, bitmap_data);
} else {
- FinalizeImage(ToBitmap(favicon.image_data->front(),
- favicon.image_data->size()), request_id);
+ FinalizeImage(ToBitmap(bitmap_data->front(), bitmap_data->size()),
+ request_id);
}
}

Powered by Google App Engine
This is Rietveld 408576698