chrome/browser/history/history_backend.h - Issue 10870022: Change FaviconData to be able to return data for multiple bitmaps for same icon URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend.h

Issue 10870022: Change FaviconData to be able to return data for multiple bitmaps for same icon URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/favicon/favicon_service.h ('K') | « chrome/browser/history/history.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | chrome/browser/history/history_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_backend.h

diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h

index 6d50cc18f68ebc0dcb8f6be4751bcbb7353e24af..a80c8e30a810794ffb287b53bf6956cd68e856b6 100644

--- a/chrome/browser/history/history_backend.h

+++ b/chrome/browser/history/history_backend.h

@@ -651,11 +651,11 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

// |favicon| is set appropriately and true is returned.

bool GetFaviconFromDB(const GURL& page_url,

int icon_types,

- FaviconData* favicon);

+ FaviconData* favicon_data);

// Get favicon by the given |favicon_id|, the |favicon| is set appropriately

// and true if returned on success, otherwise false is returned.

- bool GetFaviconFromDB(FaviconID favicon_id, FaviconData* favicon);

+ bool GetFaviconFromDB(FaviconID favicon_id, FaviconData* favicon_data);

// Notify any observers of an addition to the visit database.

void NotifyVisitObservers(const VisitRow& visit);