Change FaviconData to be able to return data for multiple bitmaps for same icon URL

chrome/browser/jumplist_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/jumplist_win.h"
 
 #include <windows.h>
 #include <shobjidl.h>
 #include <propkey.h>
 #include <propvarutil.h>
@@ skipping 26 matching lines @@
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_source.h"
 #include "googleurl/src/gurl.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/codec/png_codec.h"
+#include "ui/gfx/favicon_size.h"
 #include "ui/gfx/icon_util.h"
 
 using content::BrowserThread;
 
 namespace {
 
 // COM interfaces used in this file.
 // These interface declarations are copied from Windows SDK 7.0.
 // TODO(hbono): Bug 16903: delete them when we use Windows SDK 7.0.
 #ifndef __IObjectArray_INTERFACE_DEFINED__
@@ skipping 637 matching lines @@
   {
     base::AutoLock auto_lock(list_lock_);
     if (icon_urls_.empty())
       return false;
     // Ask FaviconService if it has a favicon of a URL.
     // When FaviconService has one, it will call OnFaviconDataAvailable().
     url = GURL(icon_urls_.front().first);
   }
   FaviconService* favicon_service =
       FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
-  handle_ = favicon_service->GetFaviconForURL(
-      profile_, url, history::FAVICON, &favicon_consumer_,
+  handle_ = favicon_service->GetFaviconImageForURL(
+      profile_, url, history::FAVICON, gfx::kFaviconSize, &favicon_consumer_,
       base::Bind(&JumpList::OnFaviconDataAvailable, base::Unretained(this)));
   return true;
 }
 
 void JumpList::OnFaviconDataAvailable(
     FaviconService::Handle handle,
-    history::FaviconData favicon) {
+    const history::FaviconImageResult& image_result) {
   // If there is currently a favicon request in progress, it is now outdated,
   // as we have received another, so nullify the handle from the old request.
   handle_ = NULL;
   // lock the list to set icon data and pop the url
   {
     base::AutoLock auto_lock(list_lock_);
     // Attach the received data to the ShellLinkItem object.
     // This data will be decoded by the RunUpdate method.
-    if (favicon.is_valid()) {
+    if (!image_result.image.IsEmpty()) {
       if (!icon_urls_.empty() && icon_urls_.front().second)
-        icon_urls_.front().second->SetIconData(favicon.image_data);
+        icon_urls_.front().second->SetIconData(image_result.image.AsBitmap());
     }
 
     if (!icon_urls_.empty())
       icon_urls_.pop_front();
   }
   // if we need to load more favicons, we send another query and exit.
   if (StartLoadingFavicon())
     return;
 
   // Finished loading all favicons needed by the application JumpList.
@@ skipping 23 matching lines @@
   // Delete the directory which contains old icon files, rename the current
   // icon directory, and create a new directory which contains new JumpList
   // icon files.
   FilePath icon_dir_old(icon_dir_.value() + L"Old");
   if (file_util::PathExists(icon_dir_old))
     file_util::Delete(icon_dir_old, true);
   file_util::Move(icon_dir_, icon_dir_old);
   file_util::CreateDirectory(icon_dir_);
 
   // Create temporary icon files for shortcuts in the "Most Visited" category.
-  DecodeIconData(local_most_visited_pages);
+  CreateIconFiles(local_most_visited_pages);
 
   // Create temporary icon files for shortcuts in the "Recently Closed"
   // category.
-  DecodeIconData(local_recently_closed_pages);
+  CreateIconFiles(local_recently_closed_pages);
 
   // We finished collecting all resources needed for updating an appliation
   // JumpList. So, create a new JumpList and replace the current JumpList
   // with it.
   UpdateJumpList(app_id_.c_str(), local_most_visited_pages,
                  local_recently_closed_pages);
 }
 
-void JumpList::DecodeIconData(const ShellLinkItemList& item_list) {
+void JumpList::CreateIconFiles(const ShellLinkItemList& item_list) {
   for (ShellLinkItemList::const_iterator item = item_list.begin();
       item != item_list.end(); ++item) {
-    SkBitmap icon_bitmap;
-    if ((*item)->data().get() &&
-        gfx::PNGCodec::Decode((*item)->data()->front(),
-                              (*item)->data()->size(),
-                              &icon_bitmap)) {
-      FilePath icon_path;
-      if (CreateIconFile(icon_bitmap, icon_dir_, &icon_path))
-        (*item)->SetIcon(icon_path.value(), 0, true);
-    }
+    FilePath icon_path;
+    if (CreateIconFile((*item)->data(), icon_dir_, &icon_path))
+      (*item)->SetIcon(icon_path.value(), 0, true);
   }
 }