Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/browser/chromeos/cros/onc_network_parser_unittest.cc

Issue 10868113: Disable certificate patterns for device policy ONC files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/cros/onc_network_parser.h" 5 #include "chrome/browser/chromeos/cros/onc_network_parser.h"
6 6
7 #include <cert.h> 7 #include <cert.h>
8 #include <keyhi.h> 8 #include <keyhi.h>
9 #include <pk11pub.h> 9 #include <pk11pub.h>
10 10
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 EXPECT_EQ(chromeos::CLIENT_CERT_TYPE_PATTERN, vpn->client_cert_type()); 325 EXPECT_EQ(chromeos::CLIENT_CERT_TYPE_PATTERN, vpn->client_cert_type());
326 EXPECT_EQ("Google, Inc.", 326 EXPECT_EQ("Google, Inc.",
327 vpn->client_cert_pattern().issuer().organization()); 327 vpn->client_cert_pattern().issuer().organization());
328 ASSERT_EQ(2ul, vpn->client_cert_pattern().enrollment_uri_list().size()); 328 ASSERT_EQ(2ul, vpn->client_cert_pattern().enrollment_uri_list().size());
329 EXPECT_EQ("http://youtu.be/dQw4w9WgXcQ", 329 EXPECT_EQ("http://youtu.be/dQw4w9WgXcQ",
330 vpn->client_cert_pattern().enrollment_uri_list()[0]); 330 vpn->client_cert_pattern().enrollment_uri_list()[0]);
331 EXPECT_EQ("chrome-extension://abc/keygen-cert.html", 331 EXPECT_EQ("chrome-extension://abc/keygen-cert.html",
332 vpn->client_cert_pattern().enrollment_uri_list()[1]); 332 vpn->client_cert_pattern().enrollment_uri_list()[1]);
333 } 333 }
334 334
335 TEST_F(OncNetworkParserTest, TestNoCertificatePatternForDevicePolicy) {
336 std::string test_blob;
337 GetTestData("cert-pattern.onc", &test_blob);
338 OncNetworkParser parser(test_blob, "",
339 NetworkUIData::ONC_SOURCE_DEVICE_POLICY);
340
341 // Make sure we fail when parsing a certificate pattern from a device policy
342 // ONC file.
343 ASSERT_TRUE(parser.parse_error().empty());
344 EXPECT_EQ(1, parser.GetNetworkConfigsSize());
345 EXPECT_EQ(2, parser.GetCertificatesSize());
346 scoped_ptr<Network> network(parser.ParseNetwork(0, NULL));
347 ASSERT_TRUE(network.get());
348
349 EXPECT_EQ(chromeos::TYPE_WIFI, network->type());
350 WifiNetwork* wifi = static_cast<WifiNetwork*>(network.get());
351 EXPECT_EQ(chromeos::SECURITY_8021X, wifi->encryption());
352 EXPECT_EQ("WirelessNetwork", wifi->name());
353 EXPECT_FALSE(wifi->auto_connect());
354 EXPECT_EQ("", wifi->passphrase());
355 EXPECT_EQ(chromeos::EAP_METHOD_TLS, wifi->eap_method());
356 EXPECT_EQ(chromeos::CLIENT_CERT_TYPE_PATTERN, wifi->client_cert_type());
357 EXPECT_EQ("", wifi->client_cert_pattern().issuer().organization());
358 ASSERT_EQ(0ul, wifi->client_cert_pattern().enrollment_uri_list().size());
359 }
360
335 TEST_F(OncNetworkParserTest, TestCreateNetworkWifiEAP1) { 361 TEST_F(OncNetworkParserTest, TestCreateNetworkWifiEAP1) {
336 std::string test_blob; 362 std::string test_blob;
337 GetTestData("network-wifi-eap1.onc", &test_blob); 363 GetTestData("network-wifi-eap1.onc", &test_blob);
338 OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT); 364 OncNetworkParser parser(test_blob, "", NetworkUIData::ONC_SOURCE_USER_IMPORT);
339 365
340 EXPECT_EQ(1, parser.GetNetworkConfigsSize()); 366 EXPECT_EQ(1, parser.GetNetworkConfigsSize());
341 EXPECT_EQ(0, parser.GetCertificatesSize()); 367 EXPECT_EQ(0, parser.GetCertificatesSize());
342 scoped_ptr<Network> network(parser.ParseNetwork(0, NULL)); 368 scoped_ptr<Network> network(parser.ParseNetwork(0, NULL));
343 ASSERT_TRUE(network.get()); 369 ASSERT_TRUE(network.get());
344 370
(...skipping 603 matching lines...) Expand 10 before | Expand all | Expand 10 after
948 EXPECT_EQ(1, parser.GetNetworkConfigsSize()); 974 EXPECT_EQ(1, parser.GetNetworkConfigsSize());
949 EXPECT_EQ(0, parser.GetCertificatesSize()); 975 EXPECT_EQ(0, parser.GetCertificatesSize());
950 bool marked_for_removal = false; 976 bool marked_for_removal = false;
951 scoped_ptr<Network> network(parser.ParseNetwork(0, &marked_for_removal)); 977 scoped_ptr<Network> network(parser.ParseNetwork(0, &marked_for_removal));
952 978
953 EXPECT_TRUE(marked_for_removal); 979 EXPECT_TRUE(marked_for_removal);
954 EXPECT_EQ("{485d6076-dd44-6b6d-69787465725f5045}", network->unique_id()); 980 EXPECT_EQ("{485d6076-dd44-6b6d-69787465725f5045}", network->unique_id());
955 } 981 }
956 982
957 } // namespace chromeos 983 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698