Report texture upload time in renderingStats.

content/common/gpu/client/gpu_channel_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_channel_host.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
@@ skipping 196 matching lines @@
   int route_id = command_buffer->GetRouteID();
   Send(new GpuChannelMsg_DestroyCommandBuffer(route_id));
   // Check the proxy has not already been removed after a channel error.
   if (proxies_.find(route_id) != proxies_.end())
     proxies_.erase(route_id);
   RemoveRoute(route_id);
   delete command_buffer;
 #endif
 }
 
+bool GpuChannelHost::CollectRenderingStats(
+    int surface_id, content::GpuRenderingStats* stats) {

[piman, 2012/08/30 22:44:11]

At a high level, why restricting here to "view" command buffers (which have a
non-null surface_id)?
It seems that this would be useful in general for any command buffer (including
"offscreen" ones), by passing their routing id instead.

+  TRACE_EVENT0("gpu", "GpuChannelHost::CollectRenderingStats");
+
+  AutoLock lock(context_lock_);
+  // An error occurred. Need to get the host again to reinitialize it.
+  if (!channel_.get())

[piman, 2012/08/30 22:44:11]

Why this? I think it's racy if called on a non-main thread. In case of lost
channel, the Send below will fail anyway.
I would very much like to avoid holding a lock while sending a sync message
(that can be very slow since it's effectively a command buffer finish).

I think we can simply get rid of the autolock and this test and we'll have the
same behavior, correct?

+    return false;
+
+  if (!Send(new GpuChannelMsg_CollectRenderingStats(surface_id, stats)))
+    return false;
+
+  return true;
+}
+
 void GpuChannelHost::AddRoute(
     int route_id, base::WeakPtr<IPC::Listener> listener) {
   DCHECK(MessageLoopProxy::current());
 
   scoped_refptr<base::MessageLoopProxy> io_loop = factory_->GetIOLoopProxy();
   io_loop->PostTask(FROM_HERE,
                     base::Bind(&GpuChannelHost::MessageFilter::AddRoute,
                                channel_filter_.get(), route_id, listener,
                                MessageLoopProxy::current()));
 }
@@ skipping 74 matching lines @@
     const GpuListenerInfo& info = it->second;
     info.loop->PostTask(
         FROM_HERE,
         base::Bind(&IPC::Listener::OnChannelError, info.listener));
   }
 
   listeners_.clear();
 }